refactor: introduce DI interfaces for StackDeleter/CdkDeleter with unit tests#616
Merged
refactor: introduce DI interfaces for StackDeleter/CdkDeleter with unit tests#616
Conversation
- Add buildDependencyGraph and deleteSingleStackFunc fields to StackDeleter for DI - Add NewStackDependencyGraphForTest helper in operation package - Add 7 flow tests: independent stacks, dependency order, complex deps (6 stacks), build graph error, circular dependency, deletion error, concurrency limit verification
Owner
Author
|
|
Replace stackDeleterIface with direct func fields (deleteStacksFunc, deleteSingleStackFunc) on both StackDeleter and CdkDeleter. Remove the thin deleteSingleStack wrapper method from StackDeleter. Fix gofmt formatting.
… to deleteStacksConcurrently
- Extract ConfigLoader, DependencyAnalyzer, StackExecutor interfaces with default implementations in separate files - StackDeleter and CdkDeleter use interfaces instead of func fields - All default implementations are public structs - Update tests to use mock implementations of interfaces
go-to-k
changed the title
- ConfigLoader interface -> IConfigLoader, DefaultConfigLoader -> ConfigLoader - DependencyAnalyzer interface -> IDependencyAnalyzer, DefaultDependencyAnalyzer -> DependencyAnalyzer - StackExecutor interface -> IStackExecutor, DefaultStackExecutor -> StackExecutor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace func-type DI fields in StackDeleter and CdkDeleter with proper interfaces, and add comprehensive unit tests.
Changes
Interfaces (new files)
config_loader.goIConfigLoaderConfigLoader(wrapsclient.LoadAWSConfig)dependency_analyzer.goIDependencyAnalyzerDependencyAnalyzer(wrapsBuildDependencyGraph)stack_executor.goIStackExecutorStackExecutor(RemoveDeletionPolicy + Preprocess + Delete)Refactored structs
StackDeleter: usesIDependencyAnalyzer+IStackExecutorinterfacesCdkDeleter: usesIConfigLoader+IDependencyAnalyzer+IStackExecutorinterfacesTests
StackDeleter (7 tests):
CdkDeleter (12 tests):