ensure constant client response body order#848
Merged
casualjim merged 1 commit intogo-swagger:masterfrom Jan 7, 2017
Merged
Conversation
Current coverage is 69.28% (diff: 100%)@@ master #848 diff @@
==========================================
Files 21 21
Lines 5863 5864 +1
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 4061 4063 +2
+ Misses 1389 1388 -1
Partials 413 413
|
casualjim
approved these changes
Jan 7, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #846
Also added a unit test to ensure the order of the Response & Body (payload).
Using a new swagger build with these changes, it now seems to appear that the order of generated objects is constant across sequential generations. Tested it for both the client and server of the EVE API Spec referenced in #846. Locally it seems to hold up, as it seemed to be only the body (extraSchemes) that were not sorted yet. Therefore I only added a unit-test to test the order of the body, as mentioned earlier.