Expose Collations array

Hi, I'm one of the maintainers on WhoDB and I've ran into a use case where I'd like to see if a given collation is supported by this library. However I'm unable to directly check it since the array is private.

mysql/collations.go

Line 24 in 85c6311

var collations = map[string]byte{

Would you be open to exposing it, or exposing a function that checks if a given string is a member of it?

I've ran into a use case where I'd like to see if a given collation is supported by this library.

Please describe the use case.
I don't want to expose the array.

I've ran into a use case where I'd like to see if a given collation is supported by this library.

Please describe the use case. I don't want to expose the array.

In the UI we expose the Collation option to users, and I want do do a check in the backend to see if whatever option they put in is supported by the library and handle accordingly.

UIs that specify only collation are not recommended.
Also, the collations in the tables in this library are not necessarily the collations that are used.
It is better to let the user freely input charset and collation respectively.

Also, the collations in the tables in this library are not necessarily the collations that are used.

Would you mind elaborating on this?

this list is exported from one specific mysql version. newer/older mysql would have different collations.

This list is used when only collation name is specified. In this case, this driver send collation id in handshake packet. But the collation id may and may not used by the server. So this is not recommended.

Instead, we recommend using only charset or pair of charset and collation. In this case, this list is not used. Instead, this driver sends SET NAMES <charset> or SET NAMES <charset> COLLATE <collation> command to the server. The collation list might used in only handshake. This approach is recommended because:

Safe. Server returns OK/NG so we can know the charset/collation is actually used.
Newer collations can be used.

If you want to provide dropdown list for collations, please get collation list by SHOW COLLATIONS. Please don't use our list.

See also: https://github.com/go-sql-driver/mysql?tab=readme-ov-file#unicode-support

I see, thank you for the explanation! Very helpful :)

packets: fix inverted unknown collation check (#1832)

Navigation Menu

Repository navigation

Expose Collations array #1665

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Expose Collations array #1665

Description

Activity

methane commented on Jan 27, 2025

modelorona commented on Jan 27, 2025

methane commented on Jan 27, 2025

modelorona commented on Jan 27, 2025

methane commented on Jan 27, 2025

methane commented on Jan 27, 2025

modelorona commented on Jan 27, 2025

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions