Skip to content

Fixed boolean validation to handle bool kind#988

Merged
deankarn merged 1 commit intogo-playground:masterfrom
V-R-Dighe:develop
Sep 16, 2022
Merged

Fixed boolean validation to handle bool kind#988
deankarn merged 1 commit intogo-playground:masterfrom
V-R-Dighe:develop

Conversation

@V-R-Dighe
Copy link
Copy Markdown
Contributor

@V-R-Dighe V-R-Dighe commented Aug 18, 2022 •
edited
Loading

Fixes Or Enhances

Make sure that you've checked the boxes below before you submit PR:

  • Tests exist or have been written that cover this particular change.

@go-playground/validator-maintainers

@V-R-Dighe V-R-Dighe requested a review from a team as a code owner August 18, 2022 08:16
@coveralls
Copy link
Copy Markdown

coveralls commented Aug 18, 2022

Coverage Status

Coverage increased (+0.005%) to 74.182% when pulling a193dc2 on V-R-Dighe:develop into 9e2ea40 on go-playground:master.

@V-R-Dighe V-R-Dighe mentioned this pull request Aug 22, 2022
Closed
1 task
@V-R-Dighe
Copy link
Copy Markdown
Contributor Author

V-R-Dighe commented Sep 13, 2022

Hello Team,
cc: @deankarn

Please review and let me know if anything more is needed from my end.

Thanks,
Vaibhav Dighe

@deankarn
Copy link
Copy Markdown
Contributor

deankarn commented Sep 14, 2022

Thanks for the reminder @V-R-Dighe sorry i just have very little time to maintain this project ATM.

will try to slip it in tomorrow.

@deankarn deankarn merged commit 1e8c614 into go-playground:master Sep 16, 2022
@kaushalnavneet kaushalnavneet mentioned this pull request Oct 6, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deankarn deankarn deankarn approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@V-R-Dighe @coveralls @deankarn