Repository navigation
fix: resolve panic when using aliases with OR operator - #1507
Merged
deankarn merged 1 commit intoDec 21, 2025
Merged
Conversation
shindonghwi
force-pushed
the
fix/alias-with-or-operator-766
branch
from
December 18, 2025 00:12
b792454 to
df02f70
Compare
shindonghwi
force-pushed
the
fix/alias-with-or-operator-766
branch
from
December 18, 2025 00:15
df02f70 to
b5ae5d3
Compare
zemzale
previously approved these changes
Dec 18, 2025
zemzale
left a comment
zemzale
left a comment
Member
There was a problem hiding this comment.
Generally looks like a good fix, just some style issues from me.
Alias lookup was missing in OR parsing logic, causing panic when using aliases like `numeric|myalias`. Fixed by adding alias check before the undefined validation panic. Fixes go-playground#766
shindonghwi
force-pushed
the
fix/alias-with-or-operator-766
branch
from
December 18, 2025 11:57
b5ae5d3 to
c3989b5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #766
Using aliases with OR operator causes panic:
The issue is that alias lookup only happens for comma-separated tags, not OR-separated ones. Fixed by adding alias check in the OR parsing logic.
Added tests for various cases (built-in aliases, custom aliases, different positions, etc).