Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: go-openapi/validate
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.22.4
Choose a base ref
...
head repository: go-openapi/validate
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.22.6
Choose a head ref
  • 3 commits
  • 12 files changed
  • 1 contributor

Commits on Dec 26, 2023

  1. fix(ci): muted warnings in CI runs due to cache conflicts

    * ci: fixed code coverage on all sub packages
    
    Signed-off-by: Frederic BIDON <[email protected]>
    fredbi committed Dec 26, 2023
    Configuration menu
    Copy the full SHA
    dd1b7cd View commit details
    Browse the repository at this point in the history

Commits on Dec 27, 2023

  1. fix(parameters): applied extra schema validation to parameters (#166)

    * fix(parameters): applied extra schema validation to parameters
    
    This PR applies an extra jsonschema validation to expanded parameters.
    
    Whenever a parameter is provided as a $ref, jsonschema validation works at the level of the unexpanded parameter only.
    It is indeed valid to declare a parameter as a json reference.
    
    The issue is that the expanded content of this parameter definition is subject only to "extra rules" (uniqueness, etc)
    and not to the basic jsonschema rules (e.g. allowed and required properties).
    
    An example is provided by go-swagger/go-swagger#2527.
    
    It seems that this situation never occured before go-swagger/go-swagger#2527 because the "parameters" section to which shared
    parameters normally point to is always fully expanded.
    
    In the case of a $ref to a schema in "definition", the invalid content of the $ref incorrectly passes validation.
    
    * fixes #165
    * contributes go-swagger/go-swagger#2527
    
    Signed-off-by: Frederic BIDON <[email protected]>
    
    * added unit test to assert that no duplicate messages are spewed out
    
    Signed-off-by: Frederic BIDON <[email protected]>
    
    ---------
    
    Signed-off-by: Frederic BIDON <[email protected]>
    fredbi authored Dec 27, 2023
    Configuration menu
    Copy the full SHA
    1d1d938 View commit details
    Browse the repository at this point in the history
  2. fixed linter for duplicate constant string

    Signed-off-by: Frederic BIDON <[email protected]>
    fredbi committed Dec 27, 2023
    Configuration menu
    Copy the full SHA
    ff196e5 View commit details
    Browse the repository at this point in the history
Loading