Pool buffers for quoted strings and byte slices #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reduces allocations when writing multiple quoted strings or byte slices, by reusing bytes.Buffers, giving a nice little speed up. name old time/op new time/op delta EncodeKeyval-8 635ns ± 2% 593ns ± 0% -6.52% (p=0.008 n=5+5) name old alloc/op new alloc/op delta EncodeKeyval-8 176B ± 0% 64B ± 0% -63.64% (p=0.008 n=5+5) name old allocs/op new allocs/op delta EncodeKeyval-8 5.00 ± 0% 4.00 ± 0% -20.00% (p=0.008 n=5+5)
Member
|
Thanks for the contribution. This code is not compatible with Go 1.2, which caused the test failure. Please remove Go 1.2 from the .travis.yml file and update this PR then it should be good to merge. |
Contributor
Author
|
Done, Travis is running |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces allocations when writing multiple quoted
strings or byte slices, by reusing bytes.Buffers, giving
a nice little speed up.