Fix AutoMigrate default value comparison for string fields (issue #7590)#7591
Fix AutoMigrate default value comparison for string fields (issue #7590)#7591jinzhu merged 5 commits intogo-gorm:masterfrom
Conversation
…ms can access this field from outside the package.
|
Fix This pull request addresses issue #7590 by refining how Key Changes• Added a Affected Areas• This summary was automatically generated by @propel-code-bot |
![propel-code-bot[bot]](https://avatars.githubusercontent.com/in/1179004?s=60&v=4){kind=small}
| case schema.String: | ||
| if dv != field.DefaultValue || dv != strings.Trim(field.DefaultValue, "'") { | ||
| alterColumn = true | ||
| } |
There was a problem hiding this comment.
[CriticalError]
Logic error in string default value comparison: The condition dv != field.DefaultValue || dv != strings.Trim(field.DefaultValue, "'") will always evaluate to true because of the OR operator. If dv == field.DefaultValue, then dv != strings.Trim(field.DefaultValue, "'") will likely be true (unless the field value has quotes). This means alterColumn will always be set to true for string fields, causing unnecessary column alterations.
The logic should use AND operator to check if the values are different in both forms:
| case schema.String: | |
| if dv != field.DefaultValue || dv != strings.Trim(field.DefaultValue, "'") { | |
| alterColumn = true | |
| } | |
| case schema.String: | |
| if dv != field.DefaultValue && dv != strings.Trim(field.DefaultValue, "'") { | |
| alterColumn = true | |
| } |
⚡ Committable suggestion
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
Context for Agents
[**CriticalError**]
Logic error in string default value comparison: The condition `dv != field.DefaultValue || dv != strings.Trim(field.DefaultValue, "'")` will always evaluate to `true` because of the OR operator. If `dv == field.DefaultValue`, then `dv != strings.Trim(field.DefaultValue, "'")` will likely be true (unless the field value has quotes). This means `alterColumn` will always be set to `true` for string fields, causing unnecessary column alterations.
The logic should use AND operator to check if the values are different in both forms:
```suggestion
case schema.String:
if dv != field.DefaultValue && dv != strings.Trim(field.DefaultValue, "'") {
alterColumn = true
}
```
⚡ **Committable suggestion**
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
File: migrator/migrator.go
Line: 566
propel-code-bot
bot
changed the title
| v2, _ := strconv.ParseBool(field.DefaultValue) | ||
| alterColumn = v1 != v2 | ||
| case schema.String: | ||
| if dv != field.DefaultValue && dv != strings.Trim(field.DefaultValue, "'") { |
There was a problem hiding this comment.
change to strings.Trim(field.DefaultValue, "'\"")?
There was a problem hiding this comment.
Got it, already updated.
|
@jinzhu Can this be merged into the main branch? |
…gorm#7590) (go-gorm#7591) * feat:Capitalize the priority field of IndexOption so that other systems can access this field from outside the package. * bugfix:AutoMigrate go-gorm#7590 * bugfix:defaultValue DefaultValue * feat：change to strings.Trim(field.DefaultValue, "'\"") for alterColumn
2 participants
bugfix:AutoMigrate #7590