avoid copying structures with embedded mutexs#7571
Merged
jinzhu merged 1 commit intogo-gorm:masterfrom Aug 28, 2025
Merged
Conversation
Fixes warning like this: assignment copies lock value to relationships: gorm.io/gorm/schema.Relationships contains sync.RWMutex
Contributor
|
This pull request addresses Golang warnings related to copying structures containing embedded mutexes, specifically sync.RWMutex within gorm.io/gorm/schema.Relationships. Changes ensure that objects with embedded mutexes are passed by reference rather than by value, preventing unsafe lock copying and eliminating the related compiler warning. Several test helper function signatures were also updated from value types to pointer types to align with these safety improvements. This summary was automatically generated by @propel-code-bot |
mackinleysmith
pushed a commit
to mackinleysmith/gorm
that referenced
this pull request
Sep 8, 2025
Fixes warning like this: assignment copies lock value to relationships: gorm.io/gorm/schema.Relationships contains sync.RWMutex
phroggyy
pushed a commit
to incident-io/gorm
that referenced
this pull request
Jan 23, 2026
Fixes warning like this: assignment copies lock value to relationships: gorm.io/gorm/schema.Relationships contains sync.RWMutex
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What did this pull request do?
Fixes warning like this:
assignment copies lock value to relationships:
gorm.io/gorm/schema.Relationships contains sync.RWMutex