Skip to content

Fix concurrent map writes #7297#7298

Merged
jinzhu merged 1 commit intogo-gorm:masterfrom
Ponywka:hotfix/concurrent-map-writes
Jan 12, 2025
Merged

Fix concurrent map writes #7297#7298
jinzhu merged 1 commit intogo-gorm:masterfrom
Ponywka:hotfix/concurrent-map-writes

Conversation

@Ponywka
Copy link
Copy Markdown
Contributor

@Ponywka Ponywka commented Dec 2, 2024

  • Do only one thing
  • Non breaking API changes
  • Tested

What did this pull request do?

Fixes fatal error: concurrent map writes error (#7297)

User Case Description

Using normalized tables

Comment thread schema/relationship.go Outdated
@Ponywka Ponywka force-pushed the hotfix/concurrent-map-writes branch from 426eae3 to bdc17d9 Compare December 9, 2024 15:01
@Ponywka
Copy link
Copy Markdown
Contributor Author

Ponywka commented Dec 9, 2024

I have no idea how to write race condition tests here. “Dirty” tests were written on #7297, but it takes several times of running tests for the bug to show itself.

@jinzhu jinzhu merged commit 9ca84b3 into go-gorm:master Jan 12, 2025
phroggyy pushed a commit to incident-io/gorm that referenced this pull request Jan 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants