Skip to content

[#6372] Fixed nullable constraint bug for columns during auto migration#7269

Merged
jinzhu merged 10 commits intogo-gorm:masterfrom
wookie0:bugfix-6372
Nov 14, 2024
Merged

[#6372] Fixed nullable constraint bug for columns during auto migration#7269
jinzhu merged 10 commits intogo-gorm:masterfrom
wookie0:bugfix-6372

Conversation

@wookie0
Copy link
Copy Markdown
Contributor

@wookie0 wookie0 commented Nov 7, 2024

  • Do only one thing
  • Non breaking API changes
  • Tested

What did this pull request do?

Fix nullable constraint bug for columns during auto migration.

User Case Description

TBD.

Copy link
Copy Markdown
Member

@a631807682 a631807682 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add some tests?

Copy link
Copy Markdown
Contributor

@daheige daheige left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good!

@wookie0
Copy link
Copy Markdown
Contributor Author

wookie0 commented Nov 7, 2024

@a631807682 @daheige
I did add test case in the previous built test function.
But some checks were not successful, I saw the CI log. But I can't find what problem is. I think test code I added is not cause. any help??

+) Also, test failed in master branch at local env.

@a631807682
Copy link
Copy Markdown
Member

a631807682 commented Nov 8, 2024

@a631807682 @daheige I did add test case in the previous built test function. But some checks were not successful, I saw the CI log. But I can't find what problem is. I think test code I added is not cause. any help??

+) Also, test failed in master branch at local env.

Fixed by go-gorm/sqlserver#134

Upgrade gorm.io/driver/sqlserver to v1.5.4

@wookie0
Copy link
Copy Markdown
Contributor Author

wookie0 commented Nov 8, 2024

@a631807682
Nice! Everything works perfectly.
Thanks!!

@jinzhu jinzhu merged commit b0d70a2 into go-gorm:master Nov 14, 2024
@chandratripmp
Copy link
Copy Markdown

hi @jinzhu @daheige @a631807682, which version will this PR be included in?

phroggyy pushed a commit to incident-io/gorm that referenced this pull request Jan 23, 2026
…migration (go-gorm#7269)

* [go-gorm#6372] Fixed nullable constraint bug for columns during auto migration

* [go-gorm#6372] fix comment

* [go-gorm#6372] Add test code

* [go-gorm#6372] Add test code

* [go-gorm#6372] Fix failed test case

* [go-gorm#6372] Fix failed test case

* [go-gorm#6372] wip

* [go-gorm#6372] wip

* [go-gorm#6372] wip

* [go-gorm#6372] wip
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants