refactor: improve logging for unimplemented ErrorTranslator in TranlateError config enabled#7225
Merged
jinzhu merged 1 commit intogo-gorm:masterfrom Oct 9, 2024
Conversation
jdon
added a commit
to incident-io/gorm
that referenced
this pull request
Jan 9, 2026
This reverts the following commits: - a1a3311 Revert change to replace directive - 11ee137 Tidy struct scanner if statement - 23b45b7 Run go fmt ./... - 0fc283c Merge remote-tracking branch 'upstream/master' - bf5cd45 Merge pull request #1 from incident-io/henrycourse/upgrade-gorm-ww24 - 65bfeca Revert go.mod migration to 1.2x+ - 52e3b35 refactor(workflow): update release workflow to enhance automation (go-gorm#7224) - 8020e8c refactor: improve logging for unimplemented ErrorTranslator in TranslateError config (go-gorm#7225)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Translate(), occur warning log. (inTestDialectorWithErrorTranslatorSupport())What did this pull request do?
If the user's config conficts with db driver's dialector implementation, a warning log will be generate to heldy identify the issue.
User Case Description
I enable
TranslateErrorconfig as true, but my MySQL DB driver (version:1.4.7) doesn't implementTransalte()method.Therefore, I had trouble identifying this situation. I think log information is necessary.