fix: strings.Title -> cases.Title bcs strings.Title library is deprecated#6999
Merged
jinzhu merged 3 commits intogo-gorm:masterfrom Jun 12, 2024
Merged
fix: strings.Title -> cases.Title bcs strings.Title library is deprecated#6999jinzhu merged 3 commits intogo-gorm:masterfrom
jinzhu merged 3 commits intogo-gorm:masterfrom
Conversation
daheige
approved these changes
Jun 11, 2024
Contributor
daheige
left a comment
daheige
left a comment
There was a problem hiding this comment.
Use golang.org/x/text/cases LGTM
jinzhu
approved these changes
Jun 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What did this pull request do?
change using library strings.Title to cases.Title because of strings. Title is deprecated for Go 1.18
below is a warnings when I run golangci-cli:
I rewrite strings.Title -> cases.Title.
cases.TItle returns a Caser so it needed to parse to string because strings.Title returns string
cases.Title can be taken language, but I don't know which language supports for gorm so I tried to write
language.Und.this means you didn't decide which language.
User Case Description