• Do only one thing
• Non breaking API changes
• Tested

What did this pull request do?

ref: #6910 (review)

Modified the Remove() method so that it not only sets the removed flag but also removes the callback from the callbacks within compile().
This resolves the following issues:

• The problem where the Get() method could retrieve callbacks that have already been removed.
• The problem where removed callbacks could still operate due to the Remove() method.

In addition, I have made some modifications to the existing tests.
Previously, the specified before and after for a callback continued to affect the overall order even after being Remove()d. I believe that continuing to have an effect after being removed is an unintended behavior.
What do you think? I would appreciate any advice.

User Case Description

The problem where the Get() method

If a callback named cb1 is registered, it is expected that calling Get("cb1") after Remove("cb1") should return nil. However, a callback function registered as cb1 is being returned instead.

db, _ := gorm.Open(nil, nil)
createCallback := db.Callback().Create()

createCallback.Register("cb1", func(*gorm.DB){})
createCallback.Remove("cb1")

cb := createCallback.Get("cb1") // not nil

The problem where the Remove() method

The expectation is that callbacks marked as removed via Remove() should not be executed. However, we encountered an issue where callbacks registered through methods like Before("*").Register() continue to operate even after being Remove()d.
This typically occurs in scenarios such as the following:

db, _ := gorm.Open(nil, nil)
rawCallback := db.Callback().Raw()

rawCallback.Before("*").Register("cb1", func(*gorm.DB) { panic("Remove does not work") })
rawCallback.Remove("cb1")

db.Exec("SELECT 1") // panic

workaround

For your reference, using Before("*").Remove() can be mentioned as a workaround for the above issue.