Fix regression in db.Not introduced in v1.25.6.#6844
Merged
jinzhu merged 2 commits intogo-gorm:masterfrom Mar 5, 2024
Merged
Conversation
a631807682
reviewed
Feb 27, 2024
a631807682
approved these changes
Feb 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What did this pull request do?
Fix #6845
Address a regression introduced in Gorm v1.25.6, specifically in commit 940358e.
The behavior of the
db.Notmethod when used with multipleWhereconditions has changed unexpectedly. Prior to v1.25.6, the querydb.Not(db.Where("a=1").Where("b=1"))would correctly translate to SQL asNOT (a=1 AND b=1). However, after the specified commit, the same query started translating to(NOT a=1 AND NOT b=1), which is a significant alteration in the logic.This PR reverts the
db.Notmethod's behavior back to its original state when *gorm.DB passed as arguments.User Case Description