Added support of "Violates Foreign Key Constraint"#6329
Merged
jinzhu merged 2 commits intogo-gorm:masterfrom May 21, 2023
Merged
Added support of "Violates Foreign Key Constraint"#6329jinzhu merged 2 commits intogo-gorm:masterfrom
jinzhu merged 2 commits intogo-gorm:masterfrom
Conversation
Updated the translator and added the support of "foreign key constraint violation". For this, this error type is needed here.
a631807682
reviewed
May 18, 2023
Contributor
Author
|
@jinzhu kindly merge this PR as it's needed for go-gorm/postgres#185 (already merged). Thanks. |
jinzhu
approved these changes
May 21, 2023
3 tasks
alidevhere
pushed a commit
to alidevhere/gorm
that referenced
this pull request
May 30, 2023
* Added support of "Violates Foreign Key Constraint" Updated the translator and added the support of "foreign key constraint violation". For this, this error type is needed here. * changed the description of ErrForeignKeyViolated
jinzhu
pushed a commit
that referenced
this pull request
May 30, 2023
* max identifier length changed to 63 * default maxIdentifierLength is 64 * renamed License to LICENSE (#6336) * Added support of "Violates Foreign Key Constraint" (#6329) * Added support of "Violates Foreign Key Constraint" Updated the translator and added the support of "foreign key constraint violation". For this, this error type is needed here. * changed the description of ErrForeignKeyViolated * refactor: error translator test (#6350) Co-authored-by: Saeid Saeidee <[email protected]> * fix(nested transaction): SavePoint SQL Statement not support in Prepared Statements (#6220) * test: add nested transaction and prepareStmt coexist test case note: please test in the MySQL environment Change-Id: I0db32adc5f74b0d443e98943d3b182236583b959 Signed-off-by: 王柳洋 <[email protected]> * fix(nested transaction): SavePoint SQL Statement not support in Prepared Statements 1. SavetPoint SQL Statement not support in Prepared Statements e.g. see mysql8.0 doc: https://dev.mysql.com/doc/refman/8.0/en/sql-prepared-statements.html Change-Id: I082012db9b140e8ec69764c633724665cc802692 Signed-off-by: 王柳洋 <[email protected]> * revert(transaction_api): remove savepoint name pool,meaningless Change-Id: I84aa9924fc54612005a81c83d66fdf8968ee56ad Signed-off-by: 王柳洋 <[email protected]> --------- Signed-off-by: 王柳洋 <[email protected]> Co-authored-by: 王柳洋 <[email protected]> * fix: save with hook (#6285) (#6294) --------- Signed-off-by: 王柳洋 <[email protected]> Co-authored-by: Avinaba Bhattacharjee <[email protected]> Co-authored-by: Muhammad Amir Ejaz <[email protected]> Co-authored-by: Saeid <[email protected]> Co-authored-by: Saeid Saeidee <[email protected]> Co-authored-by: wangliuyang <[email protected]> Co-authored-by: 王柳洋 <[email protected]> Co-authored-by: black-06 <[email protected]>
Contributor
Author
|
@jinzhu please release new changes as these are needed in gorm/postgres. Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What did this pull request do?
Updated the translator and added the support of "foreign key constraint violation". For this, this error type is needed here.
User Case Description
Lets say I have a struct RoleAssignment having RoleID as a foreign key
and I want to insert a record having role_id which does not exist in Role table, here gorm is throwing pgerror which should be translated to gorm error. As suggested below:
Pull Request for https://github.com/go-gorm created.