Skip to content

save should be idempotent#6149

Merged
jinzhu merged 1 commit intogo-gorm:masterfrom
black-06:idempotent_save
Mar 23, 2023
Merged

save should be idempotent#6149
jinzhu merged 1 commit intogo-gorm:masterfrom
black-06:idempotent_save

Conversation

@black-06
Copy link
Copy Markdown
Contributor

@black-06 black-06 commented Mar 14, 2023

  • Do only one thing
  • Non breaking API changes
  • Tested

What did this pull request do?

Save should be idempotent. #6139 #6134

When call Save twice with the same object, Save should not raise an error.

User Case Description

var company Company
DB.Frist(&company)

DB.Save(&company)
DB.Save(&company) // should not create new record or rasise an error.
DB.Save(&company) // should not create new record or rasise an error.

@jinzhu jinzhu merged commit 0c7e575 into go-gorm:master Mar 23, 2023
@black-06 black-06 mentioned this pull request Mar 23, 2023
Closed
@monoflash
Copy link
Copy Markdown

monoflash commented Mar 30, 2023

MySQL MariaDB database, same problem.
Save() does not work from version 1.24.6 to latest.
The latest version in which Save() works is v1.24.5.

@black-06 black-06 mentioned this pull request May 5, 2023
Merged
3 tasks
@szdt-model szdt-model mentioned this pull request May 26, 2023
Closed
1 task
@alingse alingse mentioned this pull request Jun 16, 2023
Closed
@jhemmmm
Copy link
Copy Markdown

jhemmmm commented Jun 17, 2023

I stopped using save as they keep having race data problems. The save should only update the column that has been changed.

@black-06
Copy link
Copy Markdown
Contributor Author

black-06 commented Jun 19, 2023

I stopped using save as they keep having race data problems. The save should only update the column that has been changed.

Not, See Save doc

Save will save all fields when performing the Updating SQL

@jhemmmm
Copy link
Copy Markdown

jhemmmm commented Jun 19, 2023

I'm aware.

@MuZhou233 MuZhou233 mentioned this pull request Mar 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@a631807682 a631807682 a631807682 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@black-06 @monoflash @jhemmmm @a631807682 @jinzhu