Skip to content

Conversation

@silverwind
Copy link
Member

@silverwind silverwind commented Dec 18, 2025

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 18, 2025
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 18, 2025
@silverwind
Copy link
Member Author

silverwind commented Dec 18, 2025

I need to test whether it's possible to have this in one config file. Not super thrilled to add another config file to the repo root. Likely this would require passing explicit list of files because the --ext option may be unsuitable.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 18, 2025
@silverwind
Copy link
Member Author

silverwind commented Dec 18, 2025

I conclude it's not possible to have a shared eslint config while retaining the ability to lint only JSON files without specifying them explicitely to eslint. So the two config files will have to remain.

@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Dec 19, 2025
@lunny lunny enabled auto-merge (squash) December 19, 2025 06:15
@lunny lunny merged commit b915e69 into go-gitea:main Dec 19, 2025
24 checks passed
@GiteaBot GiteaBot added this to the 1.26.0 milestone Dec 19, 2025
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Dec 19, 2025
@wxiaoguang wxiaoguang deleted the jsonlint branch December 19, 2025 06:28
zjjhot added a commit to zjjhot/gitea that referenced this pull request Dec 19, 2025
* giteaofficial/main:
  Add JSON linting (go-gitea#36192)
  Bump setup-node to v6, re-enable cache (go-gitea#36207)
  [skip ci] Updated translations via Crowdin
  Update chroma to v2.21.1 (go-gitea#36201)
  Disable dependabot automatic labels (go-gitea#36203)
  Bump astral-sh/setup-uv from 6 to 7 (go-gitea#36198)
  Front port changelog (go-gitea#36193)
  Bump dev-hanz-ops/install-gh-cli-action from 0.1.0 to 0.2.1 (go-gitea#36195)
  Bump aws-actions/configure-aws-credentials from 4 to 5 (go-gitea#36196)
  Bump docker/build-push-action from 5 to 6 (go-gitea#36197)
  Enable dependabot for actions (go-gitea#36191)
  Bump alpine to 3.23 (go-gitea#36185)
  Use gitRepo as parameter instead of repopath when invoking sign functions (go-gitea#36162)
  Fix bug when creating pull request (go-gitea#36166)
  Bump golangci-lint to 2.7.2, enable modernize stringsbuilder (go-gitea#36180)
  Use a migration test instead of a wrong test which populated the meta test repositories and fix a migration bug (go-gitea#36160)
  Update JS deps and eslint enhancements (go-gitea#36147)
  Add git.DIFF_RENAME_SIMILARITY_THRESHOLD option (go-gitea#36164)
  Fix OrgAssignment opts (go-gitea#36174)

# Conflicts:
#	models/user/user.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/dependencies modifies/frontend modifies/internal

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants