-
-
Notifications
You must be signed in to change notification settings - Fork 6.3k
Fix oauth2 session gob register #36017
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baf88fb to
7900b6c
Compare
7900b6c to
9829dac
Compare
Contributor
Author
f14a5bb to
4408afe
Compare
e2e7a5a to
d050b03
Compare
d050b03 to
e2cfadc
Compare
lunny
approved these changes
Nov 25, 2025
delvh
approved these changes
Nov 26, 2025
| Domain: setting.SessionConfig.Domain, | ||
| }) | ||
| if err != nil { | ||
| return nil, fmt.Errorf("failed to create session middleware: %w", err) |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if the old or the new version of this error message is better.
I think I prefer the old one.
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
silverwind
added a commit
to silverwind/gitea
that referenced
this pull request
Nov 26, 2025
* origin/main: Fix actions lint (go-gitea#36029) Fix oauth2 session gob register (go-gitea#36017)
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Nov 28, 2025
* giteaofficial/main: Fix error handling in mailer and wiki services (go-gitea#36041) Update JS deps, fix deprecations (go-gitea#36040) Fix incorrect viewed files counter if file has changed (go-gitea#36009) [skip ci] Updated translations via Crowdin Fix actions lint (go-gitea#36029) Fix oauth2 session gob register (go-gitea#36017)
techknowlogick
pushed a commit
that referenced
this pull request
Dec 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
modifies/dependencies
modifies/go
Pull requests that update Go code
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

gob.Registermust be called before SessionerFix #36016