Fix branch_protection api shows users/teams who has no readAccess (#30291) #30544
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-gitea#30291) Add some logic in `convert.ToBranchProtection` to return only the names associated with readAccess instead of returning all names. This will ensure consistency in behavior between the frontend and backend. Fixes: go-gitea#27694 --------- Co-authored-by: techknowlogick <[email protected]> Co-authored-by: wenzhuo.zhang <[email protected]> Co-authored-by: Giteabot <[email protected]>
GiteaBot
added
modifies/api
GiteaBot
added
the
lgtm/need 2
silverwind
approved these changes
Apr 17, 2024
GiteaBot
added
lgtm/need 1
lunny
approved these changes
Apr 17, 2024
GiteaBot
added
lgtm/done
silverwind
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #30291 by @edwardzhanged
Add some logic in
convert.ToBranchProtectionto return only the names associated with readAccess instead of returning all names. This will ensure consistency in behavior between the frontend and backend.Fixes: #27694