Fix wrong xorm Delete usage #27995
Merged
Fix wrong xorm Delete usage #27995
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
lng2020
commented
Nov 11, 2023
Member
Author
lng2020
left a comment
lng2020
left a comment
There was a problem hiding this comment.
Question: I didn't use db.WithTX there because registerableSource.RegisterSource() didn't have a context and it will use third-party function. Should the context be added?
Member
Author
|
CI failure is not related. Looks like the docker hub somehow not responding. |
delvh
approved these changes
Nov 11, 2023
GiteaBot
added
lgtm/need 1
Co-authored-by: delvh <[email protected]>
lunny
approved these changes
Nov 12, 2023
GiteaBot
added
lgtm/done
lunny
added
type/bug
reviewed/wait-merge
Collaborator
|
I was unable to create a backport for 1.20. @lng2020, please send one manually. 🍵 |
GiteaBot
added
backport/manual
Collaborator
|
I was unable to create a backport for 1.21. @lng2020, please send one manually. 🍵 |
This was referenced Nov 12, 2023
lafriks
pushed a commit
that referenced
this pull request
Nov 12, 2023
manually backport for #27995 The conflict is `ctx` and `db.Defaultctx`.
lafriks
pushed a commit
that referenced
this pull request
Nov 12, 2023
manually backport for #27995 The conflict is `ctx` and `db.Defaultctx`.
lng2020
added
backport/done
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Nov 13, 2023
* giteaofficial/main: [skip ci] Updated licenses and gitignores Fix wrong xorm Delete usage (go-gitea#27995) Move some JS code from `fomantic.js` to standalone files (go-gitea#27994) Fix the wrong oauth2 name (go-gitea#27993) Render email addresses as such if followed by punctuation (go-gitea#27987) Show error toast when file size exceeds the limits (go-gitea#27985)
fuxiaohei
pushed a commit
to fuxiaohei/gitea
that referenced
this pull request
Jan 17, 2024
## Bug in Gitea
I ran into this bug when I accidentally used the wrong redirect URL for
the oauth2 provider when using mssql. But the oauth2 provider still got
added.
Most of the time, we use `Delete(&some{id: some.id})` or
`In(condition).Delete(&some{})`, which specify the conditions. But the
function uses `Delete(source)` when `source.Cfg` is a `TEXT` field and
not empty. This will cause xorm `Delete` function not working in mssql.
https://github.com/go-gitea/gitea/blob/61ff91f9603806df2505907614b9006bf721b9c8/models/auth/source.go#L234-L240
## Reason
Because the `TEXT` field can not be compared in mssql, xorm doesn't
support it according to [this
PR](https://gitea.com/xorm/xorm/pulls/2062)
[related
code](https://gitea.com/xorm/xorm/src/commit/b23798dc987af776bec867f4537ca129fd66328e/internal/statements/statement.go#L552-L558)
in xorm
```go
if statement.dialect.URI().DBType == schemas.MSSQL && (col.SQLType.Name == schemas.Text ||
col.SQLType.IsBlob() || col.SQLType.Name == schemas.TimeStampz) {
if utils.IsValueZero(fieldValue) {
continue
}
return nil, fmt.Errorf("column %s is a TEXT type with data %#v which cannot be as compare condition", col.Name, fieldValue.Interface())
}
}
```
When using the `Delete` function in xorm, the non-empty fields will
auto-set as conditions(perhaps some special fields are not?). If `TEXT`
field is not empty, xorm will return an error. I only found this usage
after searching, but maybe there is something I missing.
---------
Co-authored-by: delvh <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug in Gitea
I ran into this bug when I accidentally used the wrong redirect URL for the oauth2 provider when using mssql. But the oauth2 provider still got added.
Most of the time, we use
Delete(&some{id: some.id})orIn(condition).Delete(&some{}), which specify the conditions. But the function usesDelete(source)whensource.Cfgis aTEXTfield and not empty. This will cause xormDeletefunction not working in mssql.gitea/models/auth/source.go
Lines 234 to 240 in 61ff91f
Reason
Because the
TEXTfield can not be compared in mssql, xorm doesn't support it according to this PRrelated code in xorm
When using the
Deletefunction in xorm, the non-empty fields will auto-set as conditions(perhaps some special fields are not?). IfTEXTfield is not empty, xorm will return an error. I only found this usage after searching, but maybe there is something I missing.