Skip to content

Improve diff tree spacing (#27714) #27719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
silverwind merged 1 commit into from
Oct 21, 2023
Merged

Improve diff tree spacing (#27714) #27719

silverwind merged 1 commit into from
Oct 21, 2023

Conversation

@GiteaBot
Copy link
Collaborator

@GiteaBot GiteaBot commented Oct 21, 2023

Backport #27714 by @silverwind

  1. Un-indent top-level items, matching GitHub rendering
  2. Increase item padding and add 1px gap between items

Before and After:

Screenshot 2023-10-20 at 18 37 32 Screenshot 2023-10-20 at 18 40 46

@silverwind @6543 @GiteaBot
Improve diff tree spacing (go-gitea#27714)
258affc 
1. Un-indent top-level items, matching GitHub rendering
2. Increase item padding and add 1px gap between items

Before and After:

<img width="247" alt="Screenshot 2023-10-20 at 18 37 32"
src="https://github.com/go-gitea/gitea/assets/115237/43c1ce86-1814-4a8a-9dd2-0c4a82a2be7c">
<img width="241" alt="Screenshot 2023-10-20 at 18 40 46"
src="https://github.com/go-gitea/gitea/assets/115237/b541b85b-c428-4903-becd-773ae5807495">

---------

Co-authored-by: 6543 <[email protected]>
@GiteaBot GiteaBot added modifies/frontend type/enhancement An improvement of existing functionality labels Oct 21, 2023
@GiteaBot GiteaBot added this to the 1.21.0 milestone Oct 21, 2023
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 21, 2023
@GiteaBot GiteaBot requested review from 6543 and delvh October 21, 2023 10:38
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 21, 2023
@silverwind silverwind enabled auto-merge (squash) October 21, 2023 10:39
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 21, 2023
@silverwind silverwind merged commit a398089 into go-gitea:release/v1.21 Oct 21, 2023
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jan 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@silverwind silverwind silverwind approved these changes

@delvh delvh delvh approved these changes

@6543 6543 Awaiting requested review from 6543

Assignees

@silverwind silverwind

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality

Projects

None yet

Milestone

1.21.0

Development

Successfully merging this pull request may close these issues.

3 participants

@GiteaBot @silverwind @delvh