Skip to content

Fix Org edit page bugs: renaming detection, maxlength (#24161) #24171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
techknowlogick merged 1 commit into from
Apr 17, 2023
Merged

Fix Org edit page bugs: renaming detection, maxlength (#24161) #24171

techknowlogick merged 1 commit into from
Apr 17, 2023

Conversation

@GiteaBot
Copy link
Collaborator

@GiteaBot GiteaBot commented Apr 17, 2023

Backport #24161 by @wxiaoguang

Before

  • The renaming detection is wrong (eg: pasting a new name into the input doesn't trigger the detection)
  • The renaming prompt layout is not good
  • Some MaxSize/maxlength rules is missing

image

image

After

  • Fix these problems

image

@wxiaoguang @GiteaBot
Fix Org edit page bugs: renaming detection, maxlength (go-gitea#24161)
8bc5deb 
## Before

* The renaming detection is wrong (eg: pasting a new name into the input
doesn't trigger the detection)
* The renaming prompt layout is not good
* Some MaxSize/maxlength rules is missing


![image](https://user-images.githubusercontent.com/2114189/232379191-5d0f6d10-56ca-4cec-ac52-7f77b9cb4a8a.png)


![image](https://user-images.githubusercontent.com/2114189/232379234-3289373b-9ddb-4627-ae86-f4d74589fa0c.png)

## After

* Fix these problems


![image](https://user-images.githubusercontent.com/2114189/232379098-31c6fa21-c210-4e7f-a337-b38b99670835.png)
@GiteaBot GiteaBot added this to the 1.19.2 milestone Apr 17, 2023
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Apr 17, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 17, 2023
@techknowlogick techknowlogick enabled auto-merge (squash) April 17, 2023 15:51
@techknowlogick techknowlogick added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 17, 2023
@techknowlogick techknowlogick merged commit 3d3c740 into go-gitea:release/v1.19 Apr 17, 2023
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 17, 2023
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jul 31, 2023
@techknowlogick techknowlogick deleted the backport-24161-v1.19 branch September 9, 2023 05:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@silverwind silverwind silverwind approved these changes

@jolheiser jolheiser jolheiser approved these changes

@lunny lunny Awaiting requested review from lunny

@techknowlogick techknowlogick Awaiting requested review from techknowlogick

Assignees

No one assigned

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug

Projects

None yet

Milestone

1.19.2

Development

Successfully merging this pull request may close these issues.

5 participants

@GiteaBot @silverwind @jolheiser @techknowlogick @wxiaoguang