Skip to content

Ignore port for loopback redirect URIs #21293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
6543 merged 1 commit into from
Sep 28, 2022
Merged

Ignore port for loopback redirect URIs #21293

6543 merged 1 commit into from
Sep 28, 2022

Conversation

@hickford
Copy link
Contributor

@hickford hickford commented Sep 28, 2022

@hickford hickford force-pushed the redirect branch 9 times, most recently from b5fbefc to 1b30022 Compare September 28, 2022 18:37
@hickford hickford marked this pull request as ready for review September 28, 2022 18:38
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Sep 28, 2022
@lafriks lafriks added this to the 1.18.0 milestone Sep 28, 2022
@lafriks lafriks added the type/enhancement An improvement of existing functionality label Sep 28, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 28, 2022
@6543 6543 merged commit 6a45a69 into go-gitea:main Sep 28, 2022
zjjhot added a commit to zjjhot/gitea that referenced this pull request Sep 29, 2022
@zjjhot
Merge remote-tracking branch 'upstream/main'
5f9a9b9 
* upstream/main:
  [skip ci] Updated translations via Crowdin
  Ignore port for loopback redirect URIs (go-gitea#21293)
  Improve error descriptions for unauthorized_client (go-gitea#21292)
  Consolidate more CSS rules, fix inline code on arc-green (go-gitea#21260)
@hickford hickford mentioned this pull request Oct 7, 2022
Merged
@hickford hickford mentioned this pull request Oct 7, 2022
Merged
hickford added a commit to hickford/gitea that referenced this pull request Oct 7, 2022
@hickford
Ignore port for loopback redirect URIs (go-gitea#21293)
5eda90a 
Following https://datatracker.ietf.org/doc/html/rfc8252#section-7.3

Fixes go-gitea#21285
@6543 6543 added the backport/done All backports for this PR have been created label Oct 7, 2022
wxiaoguang pushed a commit that referenced this pull request Oct 8, 2022
@hickford
Ignore port for OAuth2 loopback redirect URIs (#21293) (#21373)
672d54f 
Backport #21293

Following https://datatracker.ietf.org/doc/html/rfc8252#section-7.3

Fixes #21285
@hickford hickford mentioned this pull request Oct 8, 2022
Closed
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lafriks lafriks lafriks approved these changes

@6543 6543 6543 approved these changes

Assignees

No one assigned

Labels

backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality

Projects

None yet

Milestone

1.18.0

Development

Successfully merging this pull request may close these issues.

OAuth module missing special handling for loopback redirect URI

5 participants

@hickford @lafriks @6543 @wxiaoguang @GiteaBot