Modernize JS build scripts #19824
Merged
Modernize JS build scripts #19824
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove __dirname, use file URLs instead - Upgrade fabric dependency - Use fs/promises syntax, this breaks node 12 but we require 14 already The change in public/img/favicon.svg is not caused by the fabric upgrade, but it seems it was not properly generated when introduced.
silverwind
added
the
type/refactoring
delvh
approved these changes
May 28, 2022
GiteaBot
added
the
lgtm/need 1
Gusted
added
topic/build
Gusted
approved these changes
Jun 5, 2022
GiteaBot
added
lgtm/done
wxiaoguang
approved these changes
Jun 6, 2022
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Jun 6, 2022
* giteaofficial/main: Move some repository related code into sub package (go-gitea#19711) A minimal change to replace data calls with attr as per guidelines (go-gitea#19900) Modernize JS build scripts (go-gitea#19824) [skip ci] Updated translations via Crowdin Update MAINTAINERS (go-gitea#19896)
AbdulrhmnGhanem
pushed a commit
to kitspace/gitea
that referenced
this pull request
Aug 24, 2022
- Remove __dirname, use file URLs instead - Upgrade fabric dependency - Use fs/promises syntax, this breaks node 12 but we require 14 already The change in public/img/favicon.svg is not caused by the fabric upgrade, but it seems it was not properly generated when introduced. Co-authored-by: Lunny Xiao <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fs/promisessyntax, this breaks node 12 but we require 14 alreadyThe change in
public/img/favicon.svgis not caused by the fabric upgrade, but it seems it was not properly generated when introduced asmake generate-imagesproduces the same diff onmainbranch.