Skip to content

Update go-chi/cache to utilize Ping() #19719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
6543 merged 3 commits into from
May 15, 2022
Merged

Update go-chi/cache to utilize Ping() #19719

6543 merged 3 commits into from
May 15, 2022

Conversation

@6543
Copy link
Member

@6543 6543 commented May 15, 2022

as title

@6543 6543 added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label May 15, 2022
@6543 6543 added this to the 1.17.0 milestone May 15, 2022
@6543 6543 requested a review from Gusted May 15, 2022 18:18
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label May 15, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 15, 2022
@codecov-commenter
Copy link

codecov-commenter commented May 15, 2022

Codecov Report

❗ No coverage uploaded for pull request base (main@3a24523). Click here to learn what that means.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main   #19719   +/-   ##
=======================================
  Coverage        ?   47.28%           
=======================================
  Files           ?      958           
  Lines           ?   133594           
  Branches        ?        0           
=======================================
  Hits            ?    63164           
  Misses          ?    62779           
  Partials        ?     7651
Impacted Files Coverage Δ
modules/cache/cache.go 35.29% <0.00%> (ø)
modules/cache/cache_redis.go 2.10% <0.00%> (ø)
modules/cache/cache_twoqueue.go 1.53% <0.00%> (ø)
routers/web/healthcheck/check.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a24523...5163c7f. Read the comment docs.

@6543 6543 merged commit 00a981d into go-gitea:main May 15, 2022
@6543 6543 deleted the update_go-chi_cache branch May 15, 2022 18:43
zjjhot added a commit to zjjhot/gitea that referenced this pull request May 16, 2022
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
afa2c2a 
* giteaofficial/main:
  Fix issue overview for teams (go-gitea#19652)
  Fix nodeinfo caching and prevent NPE if cache non-existent (go-gitea#19721)
  Update go-chi/cache to utilize Ping() (go-gitea#19719)
  Disable blank issues (go-gitea#19717)
  clarify what session provider 'db' does (go-gitea#19713)
  [skip ci] Updated translations via Crowdin
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this pull request Aug 24, 2022
@6543 @AbdulrhmnGhanem
Update go-chi/cache to utilize Ping() (go-gitea#19719)
70ec9b5 
* update gitea.com/go-chi/cache -> v0.2.0

* ajust to new interface

* refactor
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@delvh delvh delvh approved these changes

+1 more reviewer

@Gusted Gusted Gusted approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.

Projects

None yet

Milestone

1.17.0

Development

Successfully merging this pull request may close these issues.

5 participants

@6543 @codecov-commenter @Gusted @delvh @GiteaBot