Skip to content

Update import paths from github.com/go-gitea to code.gitea.io #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
thibaultmeyer merged 2 commits into from
Nov 10, 2016
Merged

Update import paths from github.com/go-gitea to code.gitea.io #135

thibaultmeyer merged 2 commits into from
Nov 10, 2016

Conversation

@strk
Copy link
Member

@strk strk commented Nov 10, 2016

No description provided.

@lunny
Copy link
Member

lunny commented Nov 10, 2016

LGTM

@lunny lunny added this to the 1.0.0 milestone Nov 10, 2016
@lunny lunny added type/enhancement An improvement of existing functionality type/feature Completely new functionality. Can only be merged if feature freeze is not active. and removed in progress labels Nov 10, 2016
@strk
Copy link
Member Author

strk commented Nov 10, 2016

There, Travis is fine now. Ready to merge (just needs one more lgtm)

@thibaultmeyer thibaultmeyer merged commit 4247304 into go-gitea:master Nov 10, 2016
@strk strk deleted the importpath branch November 10, 2016 16:29
@lunny
Copy link
Member

lunny commented Nov 11, 2016

Why this was merged with one lgtm?

@thibaultmeyer
Copy link
Contributor

thibaultmeyer commented Nov 11, 2016 •
edited
Loading

Because lgtm seems bugged or misconfigured. It use a simple contains operation to find the word lgtm without checking that the comment author is different from the PR author

tboerger
tboerger reviewed Nov 11, 2016
View reviewed changes
cmd/serve.go
"github.com/go-gitea/gitea/modules/httplib"
"github.com/go-gitea/gitea/modules/log"
"github.com/go-gitea/gitea/modules/setting"
"code.gitea.io/git"
Copy link
Member

@tboerger tboerger Nov 11, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is currently not part of code.gitea.io

models/action.go
"github.com/go-gitea/git"
api "github.com/go-gitea/go-sdk/gitea"
"code.gitea.io/git"
api "code.gitea.io/go-sdk/gitea"
Copy link
Member

@tboerger tboerger Nov 11, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is totally wrong...

@tboerger
Copy link
Member

tboerger commented Nov 11, 2016

I don't understand how travis could succeed on that. IMHO we should revert these changes

@ghost
Copy link

ghost commented Nov 11, 2016

Everything just broke.

@thibaultmeyer
Copy link
Contributor

thibaultmeyer commented Nov 11, 2016 •
edited
Loading

It very strange i can go build without error but my IDE cant resolve any new dependency path.

@ghost
Copy link

ghost commented Nov 11, 2016 •
edited by ghost
Loading

I cannot go get. This is proof that the PR system needs a rework/something that prevents PRs from getting merged if they can't be built, not just on Travis CI but on multiple platforms.

~ # go get -u -tags sqlite github.com/go-gitea/gitea package code.gitea.io/gitea/cmd: unrecognized import path "code.gitea.io/gitea/cmd" (parse https://code.gitea.io/gitea/cmd?go-get=1: no go-import meta tags) package code.gitea.io/gitea/modules/setting: unrecognized import path "code.gitea.io/gitea/modules/setting" (parse https://code.gitea.io/gitea/modules/setting?go-get=1: no go-import meta tags)

@tboerger
Copy link
Member

tboerger commented Nov 11, 2016

We need to revert or fix that asap. And we need a proper drone pipeline

@thibaultmeyer
Copy link
Contributor

thibaultmeyer commented Nov 11, 2016 •
edited
Loading

fix import would be better than revert commit cause other PRs has been merged since.

@thibaultmeyer thibaultmeyer mentioned this pull request Nov 11, 2016
Closed
@tboerger tboerger added the lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. label Nov 29, 2016
@w3p706 w3p706 mentioned this pull request Mar 5, 2018
Closed
7 tasks
lunny pushed a commit to lunny/gitea that referenced this pull request Feb 7, 2019
@michaelkuhn @lafriks
command: fix NewCommand (go-gitea#135)
389d3c8 
Make an explicit copy of GlobalCommandArgs, otherwise append might
overwrite it.
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@tboerger tboerger tboerger left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality type/feature Completely new functionality. Can only be merged if feature freeze is not active.

Projects

None yet

Milestone

1.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@strk @lunny @thibaultmeyer @tboerger