IsErrNotValidReviewRequest should check if ErrNotValidReviewRequest not ErrReviewNotExist #13187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: a1012112796 <[email protected]>
lunny
approved these changes
Oct 17, 2020
GiteaBot
added
the
lgtm/need 1
Member
|
@a1012112796 Have you sent a PR to master? |
Member
Author
I has changed it in #11355, because it's not a big problem, So I think it's not necessary to send another pr to do it. Thanks. |
zeripath
approved these changes
Oct 17, 2020
GiteaBot
added
lgtm/done
Contributor
Is #11355 ready to review then? I would also adjust the leading comment in #11355 to say that it contains this PR. |
zeripath
changed the title
6543
added
the
skip-changelog
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm sorry for my fault.