-
-
Notifications
You must be signed in to change notification settings - Fork 6.3k
Closed
Labels
type/featureCompletely new functionality. Can only be merged if feature freeze is not active.Completely new functionality. Can only be merged if feature freeze is not active.type/proposalThe new feature has not been accepted yet but needs to be discussed first.The new feature has not been accepted yet but needs to be discussed first.
Description
Feature Description
A little suggestion:
Change from
<img class="ui mini image" width="30" height="30" src="/assets/img/logo.svg" alt="Logo">
to
<img class="ui mini image" width="30" height="30" src="/assets/img/logo.svg" alt="Home Page">
is more pretty nice for understanding, including but not limited to blind.
By the way, If you use SVG format, could consult GitHub code. They use aria-label property:
<a href="https://github.com/" aria-label="Homepage "><svg></svg></a>And GitLab use aria-label and a tooltip with text GitLab home page:
<a href="/" data-nav="logo" aria-label="Home" class="slp-btn slp-mr-8 slp-btn-icon" ><svg xmlns="http://www.w3.org/2000/svg" role="img" aria-labelledby="tanukiHomeDesktop"><title id="tanukiHomeDesktop">GitLab home page</title></svg></a>But for lightness, aria-label property is great and enough.
Thanks a lot!
Screenshots
No response
Metadata
Metadata
Assignees
Labels
type/featureCompletely new functionality. Can only be merged if feature freeze is not active.Completely new functionality. Can only be merged if feature freeze is not active.type/proposalThe new feature has not been accepted yet but needs to be discussed first.The new feature has not been accepted yet but needs to be discussed first.