Fix issue where you cannot checkout by tag commit hash. #964
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alee-r7
changed the title
aymanbagabas
added a commit
to aymanbagabas/go-git
that referenced
this pull request
Dec 12, 2023
Allow checking out a worktree using a tag hash id. Fixes: go-git#959 Supersedes: go-git#964
aymanbagabas
added a commit
to aymanbagabas/go-git
that referenced
this pull request
Dec 12, 2023
Allow checking out a worktree using a tag hash id. Fixes: go-git#959 Supersedes: go-git#964
aymanbagabas
added a commit
to aymanbagabas/go-git
that referenced
this pull request
Dec 12, 2023
Allow checking out a worktree using a tag hash id. Fixes: go-git#959 Supersedes: go-git#964
aymanbagabas
added a commit
to aymanbagabas/go-git
that referenced
this pull request
Dec 12, 2023
Allow checking out a worktree using a tag hash id. Fixes: go-git#959 Supersedes: go-git#964
github-actions
bot
added
the
stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current state of go-git, checking out by a commit hash ID associated with a tag is not supported. This limitation arises from the fact that, under the hood, the hash is linked to a tag. The checkout process operates under the assumption that a CommitObject should always be obtained. However, if the commit is linked to a tag, the result is a TagObject, leading to an error during type checking.
To address this issue, my solution involves checking if the initial attempt to retrieve the commit using GetCommit fails. If it does, the code then examines whether the obtained object is a TagObject. If it is, the fix involves returning the CommitObject associated with the tag by utilizing the Commit method of the TagObject.