Allow unsupported `multi_ack` capability #613

pjbgf · 2022-11-16T10:59:29Z

Azure DevOps requires capabilities multi_ack / multi_ack_detailed, which are not fully implemented and by default are included in transport.UnsupportedCapabilities.

The initial clone operations require a full download of the repository, and therefore those unsupported capabilities are not as crucial, so by removing them from that list allows for the first clone to work successfully.

Additional fetches will yield issues, therefore to support that repository users have to work from a clean clone until those capabilities are fully supported. Commits and pushes back into the repository have also been tested and work fine.

This PR adds an example for cloning Azure DevOps repositories.

Azure DevOps requires capabilities multi_ack / multi_ack_detailed, which are not fully implemented and by default are included in transport.UnsupportedCapabilities. The initial clone operations require a full download of the repository, and therefore those unsupported capabilities are not as crucial, so by removing them from that list allows for the first clone to work successfully. Additional fetches will yield issues, therefore to support that repository users have to work from a clean clone until those capabilities are fully supported. Commits and pushes back into the repository have also been tested and work fine. This change adds an example for cloning Azure DevOps repositories. Signed-off-by: Paulo Gomes <[email protected]>

In general, go-git can't clone from Azure DevOps, because the latter requires the capabilities multi_ack and multi_ack_detailed, which aren't implemented. However, there's now a workaround, which boils down to this: pretend, for the initial clone, that those capabilities _are_ supported, and expect them not to be used. (See go-git/go-git#613 for more on this workaround.) Signed-off-by: Michael Bridgen <[email protected]>

9159: Add --insecure option to `pulumi login` r=justinvp a=Frassle  # Description  Add --insecure option to `pulumi login` which disables https certificate checks. Fixes #9120 ## Checklist  - [ ] I have added tests that prove my fix is effective or that my feature works  - [ ] I have updated the [CHANGELOG-PENDING](https://github.com/pulumi/pulumi/blob/master/CHANGELOG_PENDING.md) file with my change  - [ ] Yes, there are changes in this PR that warrants bumping the Pulumi Service API version  12001: Support clones from Azure DevOps r=RobbieMcKinstry a=squaremo In general, go-git can't clone from Azure DevOps, because the latter requires the capabilities multi_ack and multi_ack_detailed, which aren't implemented. However, there's now a workaround, which boils down to this: pretend, for the initial clone, that those capabilities _are_ supported, and expect them not to be used. (See go-git/go-git#613 for more on this workaround.) I tried this with a personal Azure DevOps account; an automated test would need either a reliably long-lived Azure DevOps repo, or a test server that can mimic Azure DevOps' particular capabilities. I'm open to suggestions! 12025: [sdks/go] Delegate alias computation to the engine r=abhinav a=Zaid-Ajaj Fixes #11066 Addresses #11697 Credit to `@abhinav` for making aliases unit-testable by intercepting `RegisterResource` calls. > I did change the test slightly so that it either checks for `AliasURNs: []string` or `Aliases: []*pulumirpc.Alias` because I've made it such that one of them is `nil` depending on `supportsAliasSpecs` ## Checklist  - [x] I have added tests that prove my fix is effective or that my feature works  - [x] I have run `make changelog` and committed the `changelog/pending/<file>` documenting my change  - [ ] Yes, there are changes in this PR that warrants bumping the Pulumi Service API version  Co-authored-by: Fraser Waters <[email protected]> Co-authored-by: Michael Bridgen <[email protected]> Co-authored-by: Zaid Ajaj <[email protected]>

12001: Support clones from Azure DevOps r=RobbieMcKinstry a=squaremo In general, go-git can't clone from Azure DevOps, because the latter requires the capabilities multi_ack and multi_ack_detailed, which aren't implemented. However, there's now a workaround, which boils down to this: pretend, for the initial clone, that those capabilities _are_ supported, and expect them not to be used. (See go-git/go-git#613 for more on this workaround.) I tried this with a personal Azure DevOps account; an automated test would need either a reliably long-lived Azure DevOps repo, or a test server that can mimic Azure DevOps' particular capabilities. I'm open to suggestions! 12025: [sdks/go] Delegate alias computation to the engine r=abhinav a=Zaid-Ajaj Fixes #11066 Addresses #11697 Credit to `@abhinav` for making aliases unit-testable by intercepting `RegisterResource` calls. > I did change the test slightly so that it either checks for `AliasURNs: []string` or `Aliases: []*pulumirpc.Alias` because I've made it such that one of them is `nil` depending on `supportsAliasSpecs` ## Checklist  - [x] I have added tests that prove my fix is effective or that my feature works  - [x] I have run `make changelog` and committed the `changelog/pending/<file>` documenting my change  - [ ] Yes, there are changes in this PR that warrants bumping the Pulumi Service API version  Co-authored-by: Michael Bridgen <[email protected]> Co-authored-by: Zaid Ajaj <[email protected]>

In general, go-git can't clone from Azure DevOps, because the latter requires the capabilities multi_ack and multi_ack_detailed, which aren't implemented. However, there's now a workaround, which boils down to this: pretend, for the initial clone, that those capabilities _are_ supported, and expect them not to be used. (See go-git/go-git#613 for more on this workaround.) Signed-off-by: Michael Bridgen <[email protected]>

codablock · 2023-06-27T21:32:38Z

Additional fetches will yield issues

@pjbgf Can you explain in more detail how this will manifest? Will a fetch result in a detectable error or will it silently corrupt the repo?

I'm currently trying to fix Azure DevOps support and my though was that I would modify transport.UnsupportedCapabilities according to your example and then react on Fetch() errors with a fresh re-clone of the whole repository. This would however require that errors are always properly reported.

pjbgf · 2023-06-28T08:59:20Z

@codablock It won't corrupt the repository, but any follow-up fetch operations will fail - I don't recall the specific error now.

The most optimal approach I found for this without making anything Azure DevOps specific was to use ls-remote to detect changes, and if so do a new shallow clone.

codablock · 2023-06-28T11:37:21Z

@pjbgf Thanks for the response, that reassures that my approach should work.

I'm also using ls-remote to pre-detect if a fetch is required (for different reasons however, but it played into my cards now). I however decided to check for the existence of multi_ack in the returned err.String() of Fetch() and then assume that https://github.com/go-git/go-git/pull/613/files#diff-7d88eba281e953fbedac05d3dc4f71400d8621be2a110964b17a44b1b4c3424bR59 kicked in. In that case, I perform a fresh clone.

More info in go-git/go-git#613 .

This was referenced Nov 16, 2022

Git Clone does not work with Azure DevOps repos #64

Closed

git: Requirements to move back to go-git/go-git fluxcd/pkg#397

Closed

mcuadros merged commit 71f6540 into go-git:master Nov 16, 2022

pjbgf deleted the unsupported branch November 16, 2022 11:26

chenbh mentioned this pull request Dec 6, 2022

Move back to go-git buildpacks-community/kpack#1084

Closed

This was referenced Jan 1, 2023

feature: Scan Remote repository - Azure kubescape/kubescape#954

Closed

added Azure repo scanning support kubescape/kubescape#999

Closed

added Azure repo scanning support kubescape/kubescape#1012

Merged

squaremo mentioned this pull request Jan 19, 2023

Unable to clone Azure DevOps repo pulumi/pulumi-kubernetes-operator#286

Closed

squaremo mentioned this pull request Jan 26, 2023

Support clones from Azure DevOps pulumi/pulumi#12001

Merged

lunar-renovate mentioned this pull request Jan 28, 2023

Update go package upgrades - autoclosed lunarway/release-manager#469

Closed

1 task

weafscast mentioned this pull request Mar 27, 2023

sync with upstream commits argoproj-labs/go-git#9

Merged

codablock mentioned this pull request Jun 27, 2023

fix: Add workaround to support Azure DevOps and other protocol-v2 git repos kluctl/kluctl#637

Merged

1 task

stuggi added a commit to stuggi/osp-director-operator that referenced this pull request Aug 4, 2023

Add transport workaround to git_util if azure dev ops is used

d444ab0

More info in go-git/go-git#613 .

stuggi added a commit to stuggi/osp-director-operator that referenced this pull request Aug 4, 2023

Add transport workaround to git_util if azure dev ops is used

f591e63

More info in go-git/go-git#613 .

stuggi added a commit to stuggi/osp-director-operator that referenced this pull request Aug 4, 2023

Retry for Azure GitOps with capability.ThinPack

c7522cc

More info in go-git/go-git#613 .

stuggi added a commit to stuggi/osp-director-operator that referenced this pull request Aug 4, 2023

Retry for Azure GitOps with capability.ThinPack

20be642

More info in go-git/go-git#613 .

stuggi added a commit to stuggi/osp-director-operator that referenced this pull request Aug 4, 2023

Retry for Azure GitOps with capability.ThinPack

67e00a3

More info in go-git/go-git#613 .

stuggi added a commit to stuggi/osp-director-operator that referenced this pull request Aug 4, 2023

Retry for Azure GitOps with capability.ThinPack

d4a0cce

More info in go-git/go-git#613 .

stuggi mentioned this pull request Aug 4, 2023

Retry for Azure GitOps with capability.ThinPack openstack-k8s-operators/osp-director-operator#891

Merged

openshift-cherrypick-robot pushed a commit to openshift-cherrypick-robot/osp-director-operator that referenced this pull request Aug 4, 2023

Retry for Azure GitOps with capability.ThinPack

01fc4ac

More info in go-git/go-git#613 .

agilgur5 mentioned this pull request Nov 5, 2023

Authentication issue on Azure devops with the git artifact example argoproj/argo-workflows#11705

Closed

This was referenced Jan 4, 2024

Fix azure devops git clone error rancher/gitjob#400

Merged

Fix azure devops git clone error rancher/gitjob#404

Merged

pjbgf mentioned this pull request Feb 5, 2025

Deserialization In Redpanda Console Using Azure Dev Ops redpanda-data/console#1331

Closed

begamnify mentioned this pull request Mar 6, 2025

import.git unable to import from Azure DevOps Repository grafana/alloy#2924

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Allow unsupported `multi_ack` capability #613

Allow unsupported `multi_ack` capability #613

Uh oh!

pjbgf commented Nov 16, 2022

Uh oh!

codablock commented Jun 27, 2023

Uh oh!

pjbgf commented Jun 28, 2023

Uh oh!

codablock commented Jun 28, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Allow unsupported multi_ack capability #613

Allow unsupported multi_ack capability #613

Uh oh!

Conversation

pjbgf commented Nov 16, 2022

Uh oh!

codablock commented Jun 27, 2023

Uh oh!

pjbgf commented Jun 28, 2023

Uh oh!

codablock commented Jun 28, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Allow unsupported `multi_ack` capability #613

Allow unsupported `multi_ack` capability #613