Add quotes around option values with hash in git config files #611
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sh to prevent the hash being interpreted as a file comment
| for _, o := range opts { | ||
| pattern := "\t%s = %s\n" | ||
| if strings.Contains(o.Value, "\\") { | ||
| if strings.Contains(o.Value, "\\") || strings.Contains(o.Value, "#") { |
Member
|
I merged #354 , thanks for your time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for #309 'Can't clone branch ref name with hash/number sign (#)'
The problem is occurring because the # character in a git config file is interpreted as a comment.
When a repository is cloned a config file is created in the .git directory. I have mocked up an example below by hand:
However, if there is a # character in the branch name like this:
When go-git reads back the file it ignores everything after the # character, so the value read for the fetch option, rather than looking like this:
It is read back from the file as this:
go-git then returns an error 'malformed refspec, separators are wrong' because it is expecting at least one ':' separator character in that value.
The fix is to add quotes when encoding that file, so it looks like this:
Then when reading and decoding that file go-git gets the correct value.