plumbing: format/packfile, Test patchDeltaWriter cap#2086
Merged
Conversation
hiddeco
force-pushed
the
patchdeltawriter-target-cap
branch
4 times, most recently
from
b975883 to
b0774f2
Compare
`patchDeltaWriter`'s preemptive `Buffer.Grow` is already clamped at `maxPatchPreemptionSize` since `5b89cb5a`, but no test covered that path end-to-end. Add a regression test that constructs a delta whose header advertises a `math.MaxInt64` `targetSz` and asserts the call returns an error rather than driving the allocation. Also restate the rationale for the clamp in the comment, naming both the input-validation goal and the symmetry with `patchDelta`. Assisted-by: Claude Opus 4.7 Signed-off-by: Hidde Beydals <[email protected]>
hiddeco
force-pushed
the
patchdeltawriter-target-cap
branch
from
b0774f2 to
5d45247
Compare
hiddeco
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
patchDeltaWriter's preemptiveBuffer.Growis already clamped atmaxPatchPreemptionSizesince 5b89cb5, but no test covered that path end-to-end. Add a regression test that constructs a delta whose header advertises amath.MaxInt64targetSzand asserts the call returns an error rather than driving the allocation.Also restate the rationale for the clamp in the comment, naming both the input-validation goal and the symmetry with
patchDelta.