Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes reliance on the deprecated/removed ChrootOS implementation in go-billy (v6) by updating tests and simplifying .git alternates path handling to avoid the prior chroot-specific type check.
Changes:
- Removed
ChrootOS-specific test cases (keepingBoundOS) in dotgit-related filesystem tests. - Updated
DotGit.Alternates()to handle absolute alternates paths without depending onhelper/chroot+ reflection. - Replaced go-billy
util.TempDir/TempFile/WriteFileusage in several tests withtesting.T.TempDir()+os.WriteFile/os.MkdirAll.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| storage/filesystem/dotgit/writers_test.go | Drops ChrootOS variants from permission/read-only writer tests. |
| storage/filesystem/dotgit/dotgit.go | Removes reflection/chroot helper dependency; adjusts alternates absolute-path normalization. |
| storage/filesystem/dotgit/dotgit_test.go | Drops ChrootOS variant from an issue regression test matrix. |
| storage/filesystem/config_test.go | Uses TempDir() instead of go-billy temp dir helper in suite setup. |
| plumbing/transport/ssh/auth_extended_test.go | Uses TempDir() + os.WriteFile instead of go-billy temp file utilities. |
| config/config_test.go | Uses TempDir() + os filesystem operations instead of go-billy temp dir/file helpers. |
Signed-off-by: Paulo Gomes <[email protected]>
pjbgf
force-pushed
the
v6-test
branch
3 times, most recently
from
b9b718e to
e10d74e
Compare
Signed-off-by: Paulo Gomes <[email protected]>
Signed-off-by: Paulo Gomes <[email protected]>
Signed-off-by: Paulo Gomes <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
ChrootOSimplementation fromgo-billyhas been deprecated inv5and completely removed fromv6. This change removes that dependency.