plumbing: ssh, fix concurrent test failures due to cert key generation#2043
Merged
Conversation
Before we added t.Parallel to run test in parallel, the test known_hosts file was generated once and memoized for reuse across test functions. This was done to avoid the overhead of generating new keys for each test function, which can be slow. However, with tests now running in parallel, this shared state caused concurrent test failures when multiple tests tried to generate and memoize cert keys at the same time. Moreover, the key generation in general takes a negligible amount of time compared to the overall test runtime, so the memoization optimization is not as critical as it once was. Signed-off-by: Ayman Bagabas <[email protected]>
pjbgf
approved these changes
Apr 30, 2026
Member
pjbgf
left a comment
pjbgf
left a comment
There was a problem hiding this comment.
@aymanbagabas thanks for working on this. 🙇
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before we added t.Parallel to run test in parallel, the test known_hosts file was generated once and memoized for reuse across test functions. This was done to avoid the overhead of generating new keys for each test function, which can be slow. However, with tests now running in parallel, this shared state caused concurrent test failures when multiple tests tried to generate and memoize cert keys at the same time.
Moreover, the key generation in general takes a negligible amount of time compared to the overall test runtime, so the memoization optimization is not as critical as it once was.
Fixes: https://github.com/go-git/go-git/actions/runs/25137758637/job/73680183936?pr=2042