git: repository, fix DeleteBranch failing with full ref name#1951
Merged
Conversation
Strip refs/heads/ prefix from the branch name before looking up the config, so callers can pass either short names or full reference names. Fixes go-git#1189
Contributor
Author
|
Thanks for the quick merge! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
DeleteBranch("refs/heads/test")returnsErrBranchNotFoundeven when the branch exists. This happens becauseBranches()returns full reference names butDeleteBranch()looks upcfg.Branchesby short name only.The fix strips the
refs/heads/prefix before the config lookup, so bothDeleteBranch("test")andDeleteBranch("refs/heads/test")work. This matchesgit branch -dwhich accepts both forms.Link to tracking issue
Fixes #1189
Testing
Added
TestDeleteBranchFullRefNamewhich creates a branch and deletes it using the fullrefs/heads/name.go test ./...andgo vet ./...pass.Documentation
N/A
This contribution was developed with AI assistance (Codex).