sha256: Add support for Init for memory.Storage
#1667
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjbgf
force-pushed
the
sha256-init
branch
2 times, most recently
from
8be885c to
c9b1f1d
Compare
This was referenced Sep 29, 2025
Signed-off-by: Paulo Gomes <[email protected]>
Instead of returning nil for unsupported formats, defaults to SHA1. The validation for invalid object format is likely better suited around the Config logic. Signed-off-by: Paulo Gomes <[email protected]>
Signed-off-by: Paulo Gomes <[email protected]>
Signed-off-by: Paulo Gomes <[email protected]>
This is a stepping stone for enabling SHA256 in memory storage. Signed-off-by: Paulo Gomes <[email protected]>
Presently the repository_tests has over 3k lines of code. As new tests are created to support SHA256, the existing tests should be reviewed and improved. The new TestInit is table driven and uses a new forEachFormat helper function, to make it easier to extend tests to SHA256 repositories. Signed-off-by: Paulo Gomes <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the support for SHA256 Init operations for
memory.Storage. Follow-up PRs will introduce support forOpen,Cloneand other operations (and storage options).Relates to #706.