fix build on Windows #1663
fix build on Windows #1663
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a build issue on Windows by adding error tolerance to the SSH known hosts configuration step. The problem occurs because Win32-OpenSSH doesn't support the new post-quantum key exchange method ([email protected]) recently added to GitHub's SSH configuration.
- Adds
continue-on-error: trueto the "Configure known hosts" step to prevent build failures on Windows - Allows the workflow to proceed even if the SSH key configuration fails on non-Ubuntu platforms
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
|
||
| - name: Configure known hosts | ||
| continue-on-error: true | ||
| if: matrix.platform != 'ubuntu-latest' |
There was a problem hiding this comment.
Consider making the error handling more specific to Windows instead of all non-Ubuntu platforms. The issue described affects Win32-OpenSSH specifically, so using if: matrix.platform == 'windows-latest' would be more precise and allow other non-Ubuntu platforms to fail appropriately if they encounter genuine SSH configuration issues.
| if: matrix.platform != 'ubuntu-latest' | |
| if: matrix.platform == 'windows-latest' |
georg
force-pushed
the
fix-ssh-keyscan-windows
branch
2 times, most recently
from
6cb4f41 to
8db9fd9
Compare
Ignore adding github.com keys to known_hosts. Win32-OpenSSH does not support the key exchange method [email protected]. This method was recently added to github.com - see https://github.blog/engineering/platform-security/post-quantum-security-for-ssh-access-on-github/ For more information about the KEX method support see PowerShell/Win32-OpenSSH#2140
georg
force-pushed
the
fix-ssh-keyscan-windows
branch
from
8db9fd9 to
65d6418
Compare
2 participants
Ignore adding github.com keys to known_hosts.
Win32-OpenSSH does not support the key exchange method [email protected].
This method was recently added to github.com - see https://github.blog/engineering/platform-security/post-quantum-security-for-ssh-access-on-github/
For more information about the KEX method support see PowerShell/Win32-OpenSSH#2140
Thanks to Levi in go-git Discord for the
continue-on-errortip.