[v6-exp] plumbing: Improve PACK trace by redacting binary data#1214
Merged
Conversation
Previously, the trace would output the raw packfile data, which wasn't very useful. This change replaces the binary data with '[ PACKDATA ]' instead of the raw data, resulting in lines such as the following: 22:31:38.937878 pktline.go:224: packet: < 6005 [ PACKDATA ] 22:31:38.943047 pktline.go:224: packet: < 4005 [ PACKDATA ] 22:31:38.943865 pktline.go:224: packet: < 2005 [ PACKDATA ] Signed-off-by: Paulo Gomes <[email protected]>
The test execution in Windows is flaky and frequently fails due to timeout, the 50% bump aims to decrease the failure rate. Signed-off-by: Paulo Gomes <[email protected]>
hiddeco
approved these changes
Oct 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the trace would output the raw packfile data, which wasn't very useful. This change replaces the binary data with '[ PACKDATA ]' instead of the raw data, resulting in lines such as the following: