plumbing: fix unintended pointer mutation in test

hiddeco · hiddeco · commit 9bbc93b719b1 · 2025-04-12T12:04:29.000+02:00
Signed-off-by: Hidde Beydals &lt;hidde@hhh.computer&gt;
diff --git a/plumbing/transport/http/common_test.go b/plumbing/transport/http/common_test.go
@@ -111,12 +111,12 @@ func (s *ClientSuite) TestNewUnexpectedError(c *C) {
 
 func (s *ClientSuite) Test_newSession(c *C) {
 	cl := NewClientWithOptions(nil, &ClientOptions{
-		CacheMaxEntries: 2,
+		CacheMaxEntries: 3,
 	}).(*client)
 
-	insecureEP := s.Endpoint
+	insecureEP := *s.Endpoint
 	insecureEP.InsecureSkipTLS = true
-	session, err := newSession(cl, insecureEP, nil)
+	session, err := newSession(cl, &insecureEP, nil)
 	c.Assert(err, IsNil)
 
 	sessionTransport := session.client.Transport.(*http.Transport)
@@ -131,7 +131,7 @@ func (s *ClientSuite) Test_newSession(c *C) {
 
 	caEndpoint := insecureEP
 	caEndpoint.CaBundle = []byte("this is the way")
-	session, err = newSession(cl, caEndpoint, nil)
+	session, err = newSession(cl, &caEndpoint, nil)
 	c.Assert(err, IsNil)
 
 	sessionTransport = session.client.Transport.(*http.Transport)
@@ -146,7 +146,7 @@ func (s *ClientSuite) Test_newSession(c *C) {
 	// cached transport should be the one that's used.
 	c.Assert(sessionTransport, Equals, t)
 
-	session, err = newSession(cl, caEndpoint, nil)
+	session, err = newSession(cl, &caEndpoint, nil)
 	c.Assert(err, IsNil)
 	sessionTransport = session.client.Transport.(*http.Transport)
 	// transport that's going to be used should be cached already.
@@ -156,7 +156,7 @@ func (s *ClientSuite) Test_newSession(c *C) {
 
 	// if the cache does not exist, the transport should still be correctly configured.
 	cl.transports = nil
-	session, err = newSession(cl, insecureEP, nil)
+	session, err = newSession(cl, &insecureEP, nil)
 	c.Assert(err, IsNil)
 
 	sessionTransport = session.client.Transport.(*http.Transport)
