You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 1f38e17
Browse filesBrowse the repository at this point in the historyBrowse files
A packfile object header carries the object's uncompressed size, and
a well-formed packfile never produces more inflated bytes than that
value. Enforce this structural invariant at every site that consumes
the inflated stream and surface mismatches as
`ErrInflatedSizeMismatch`.
Both `Scanner.NextObject` and `Scanner.ReadObject` capture the
declared length from the most recent `pendingObject` before clearing
it, then thread that bound into `copyObject`. The shared
`copyObject(w, declaredSize)` wraps its writer in a new
`boundedWriter` when a positive size is supplied, so an overrun
returns the legal prefix alongside `ErrInflatedSizeMismatch` rather
than being silently appended. Callers in `parser.go` and
`packfile.go` go through `NextObject`, so they pick up the bound
without further changes; for delta entries the declared length is
the size of the delta instruction stream, not the resolved result,
which matches what these call sites already pass through.
The lazy `FSObject.Reader` big-object path returns a new
`boundedReadCloser` that wraps the underlying zlib-backed reader.
It builds on `io.LimitedReader` with the standard overrun-detection
trick — request `limit + 1` bytes and treat the sentinel byte as an
explicit signal — so an `io.ReadAll` on an opened object cannot
stream past the declared size. The bound is `o.size`, the resolved
object size, which matches what the caller is reading regardless of
whether the underlying entry is a non-delta or delta-resolved
object. The type and its constructor are unexported for now; they
can be promoted once a stable use case outside the package emerges.
These changes do not reject any conforming pack.
Backport of #2119.
Assisted-by: Claude Opus 4.7
Signed-off-by: Hidde Beydals <[email protected]>
0 commit comments