Add support for Chmod on billy.Filesystem#171
Merged
pjbgf merged 1 commit intogo-git:releases/v5.xfrom Dec 4, 2025
Merged
Conversation
Contributor
Author
|
@pjbgf as hinted at in #157, I'd love to see this backported 🙂 Differences to the version on main are the usage of |
pjbgf
requested changes
Dec 4, 2025
Member
pjbgf
left a comment
pjbgf
left a comment
There was a problem hiding this comment.
Thanks for backporting this @bitfehler. Just a nit, otherwise LGTM:
bitfehler
force-pushed
the
releases/v5.x
branch
from
625098d to
a78cbd0
Compare
The billy package contains a `Change` interface type, which seems to have gone unused for several years now, presumably due to the difficulty of implementing most of the required methods for all supported platforms. This commit splits out a `Chmod` interface from it, which is supported on all platforms. The interface is implemented in all applicable abstractions. Supporting `chmod` in billy would help with issues such as go-git/go-git#588 This is a backport of commit 601c531 on main (go-git#157). Signed-off-by: Conrad Hoffmann <[email protected]>
bitfehler
force-pushed
the
releases/v5.x
branch
from
a78cbd0 to
94b84fc
Compare
pjbgf
approved these changes
Dec 4, 2025
Member
pjbgf
left a comment
pjbgf
left a comment
There was a problem hiding this comment.
@bitfehler thanks for working on this. 🙇
pjbgf
added a commit
to pjbgf/go-billy
that referenced
this pull request
Feb 24, 2026
This is a follow-up to go-git#171. Signed-off-by: Paulo Gomes <[email protected]>
pjbgf
added a commit
to pjbgf/go-billy
that referenced
this pull request
Feb 24, 2026
This is a follow-up to go-git#171. Signed-off-by: Paulo Gomes <[email protected]>
pjbgf
added a commit
to pjbgf/go-billy
that referenced
this pull request
Feb 24, 2026
This is a follow-up to go-git#171. Signed-off-by: Paulo Gomes <[email protected]>
pjbgf
added a commit
to pjbgf/go-billy
that referenced
this pull request
Feb 24, 2026
This is a follow-up to go-git#171. Signed-off-by: Paulo Gomes <[email protected]>
pjbgf
added a commit
to pjbgf/go-billy
that referenced
this pull request
Feb 25, 2026
This is a follow-up to go-git#171. Signed-off-by: Paulo Gomes <[email protected]>
pjbgf
added a commit
to pjbgf/go-billy
that referenced
this pull request
Feb 25, 2026
This is a follow-up to go-git#171. Signed-off-by: Paulo Gomes <[email protected]>
arthurzam
pushed a commit
to gentoo-golang-dist/forgejo-runner
that referenced
this pull request
Feb 27, 2026
This PR contains the following updates: | Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) | |---|---|---|---| | [github.com/go-git/go-billy/v5](https://github.com/go-git/go-billy) | `v5.6.2` -> `v5.8.0` |  |  | --- ### Release Notes <details> <summary>go-git/go-billy (github.com/go-git/go-billy/v5)</summary> ### [`v5.8.0`](https://github.com/go-git/go-billy/releases/tag/v5.8.0) [Compare Source](go-git/go-billy@v5.7.0...v5.8.0) #### What's Changed - build: Update module golang.org/x/net to v0.45.0 \[SECURITY] (releases/v5.x) by [@​go-git-renovate](https://github.com/go-git-renovate)\[bot] in [#​183](go-git/go-billy#183) - v5: Ensure Chmod behaviour across BoundOS and ChrootOS by [@​pjbgf](https://github.com/pjbgf) in [#​187](go-git/go-billy#187) **Full Changelog**: <go-git/go-billy@v5.7.0...v5.8.0> ### [`v5.7.0`](https://github.com/go-git/go-billy/releases/tag/v5.7.0) [Compare Source](go-git/go-billy@v5.6.2...v5.7.0) #### What's Changed - Add support for Chmod on billy.Filesystem by [@​bitfehler](https://github.com/bitfehler) in [#​171](go-git/go-billy#171) - build: Update module golang.org/x/net to v0.38.0 \[SECURITY] (releases/v5.x) by [@​go-git-renovate](https://github.com/go-git-renovate)\[bot] in [#​177](go-git/go-billy#177) **Full Changelog**: <go-git/go-billy@v5.6.2...v5.7.0> </details> --- ### Configuration 📅 **Schedule**: Branch creation - Between 12:00 AM and 03:59 AM ( * 0-3 * * * ) (UTC), Automerge - Between 12:00 AM and 03:59 AM ( * 0-3 * * * ) (UTC). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My41LjAiLCJ1cGRhdGVkSW5WZXIiOiI0My41LjAiLCJ0YXJnZXRCcmFuY2giOiJtYWluIiwibGFiZWxzIjpbIktpbmQvRGVwZW5kZW5jeVVwZGF0ZSIsInJ1bi1lbmQtdG8tZW5kLXRlc3RzIl19--> Reviewed-on: https://code.forgejo.org/forgejo/runner/pulls/1409 Reviewed-by: Mathieu Fenniak <[email protected]> Co-authored-by: Renovate Bot <[email protected]> Co-committed-by: Renovate Bot <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The billy package contains a
Changeinterface type, which seems to have gone unused for several years now, presumably due to the difficulty of implementing most of the required methods for all supported platforms.This commit splits out a
Chmodinterface from it, which is supported on all platforms. The interface is implemented in all applicable abstractions.Supporting
chmodin billy would help with issues such as go-git/go-git#588This is a backport of commit 601c531 on main (#157).