Skip to content

reduce size of Context struct from 216 bytes to 208 bytes#912

Merged
pkieltyka merged 1 commit intogo-chi:masterfrom
juburr:master
May 7, 2024
Merged

reduce size of Context struct from 216 bytes to 208 bytes#912
pkieltyka merged 1 commit intogo-chi:masterfrom
juburr:master

Conversation

@juburr
Copy link
Contributor

@juburr juburr commented May 7, 2024

optimize memory alignment of Context struct

@pkieltyka pkieltyka merged commit ef31c0b into go-chi:master May 7, 2024
@pkieltyka
Copy link
Member

thanks :) thats a fun one

@VojtechVitek
Copy link
Contributor

every byte counts :) thanks!

Copy link

@dandee dandee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It removes original comment that gives insight what this flag does.

BTW: is "methodTyp" type name correct or a typo? Should it read "methodType"?

@pkieltyka
Copy link
Member

its intentional :) just because "type" is a keyword, so just been using "typ", in this case, of course it doesn't apply, but its there for consistency

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants