Use RoutePath in URLFormat middleware#718
Merged
pkieltyka merged 1 commit intogo-chi:masterfrom Oct 27, 2022
Merged
Conversation
Contributor
Author
|
Without this, sub routers break when adding URLFormat middleware. A possible workaround would be to just always use URLFormat at the top level router before any RoutePath is set, but being able to apply this middleware only to a subset of routes is nice. |
ProjectMutilation
added a commit
to ProjectMutilation/chi
that referenced
this pull request
Jul 9, 2025
Fixes: 0fe6bf1 ("Use RoutePath in URLFormat middleware (go-chi#718)") Found by PostgresPro with Svace Static Analyzer Signed-off-by: Maksim Korotkov <[email protected]>
ProjectMutilation
added a commit
to ProjectMutilation/chi
that referenced
this pull request
Jul 9, 2025
Fixes: 0fe6bf1 ("Use RoutePath in URLFormat middleware (go-chi#718)") Found by PostgresPro with Svace Static Analyzer Signed-off-by: Maksim Korotkov <[email protected]>
ProjectMutilation
added a commit
to ProjectMutilation/chi
that referenced
this pull request
Jul 17, 2025
Fixes: 0fe6bf1 ("Use RoutePath in URLFormat middleware (go-chi#718)") Found by PostgresPro with Svace Static Analyzer Signed-off-by: Maksim Korotkov <[email protected]>
VojtechVitek
pushed a commit
that referenced
this pull request
Aug 15, 2025
Fixes: 0fe6bf1 ("Use RoutePath in URLFormat middleware (#718)") Found by PostgresPro with Svace Static Analyzer Signed-off-by: Maksim Korotkov <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the URLFormat middleware is resetting the RoutePath to the full URL when used in a sub-router. This change makes it look at the RoutePath, if it exists, and uses that instead of the full URL.