Ability to specify response HTTP status code for Throttle middleware#571
Merged
VojtechVitek merged 2 commits intogo-chi:masterfrom Sep 18, 2024
Merged
Conversation
Member
|
thanks for the PR. I'll need to find some head space to think about this |
|
Any news on this PR? Agree with @vasayxtx, allowing to custom the status code (eg. 503) is better than always returning 429. It is misleading for the clients of the service, if they receive a 429 error will think are reaching their limits and that modifying the pace will make the error go away, but no, they will continue getting the errors, so is more suitable in this case 503. |
vasayxtx
force-pushed
the
throttle-middleware-custom-status-code
branch
from
3430082 to
a62d96e
Compare
Contributor
Author
|
I've just resolved the conflict, so the PR is ready for review/merge:) |
vasayxtx
force-pushed
the
throttle-middleware-custom-status-code
branch
2 times, most recently
from
6b3da1b to
bccb994
Compare
vasayxtx
force-pushed
the
throttle-middleware-custom-status-code
branch
from
bccb994 to
c9c6c17
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some time ago the PR #528 was merged but seems like in some cases 503 HTTP code is more suitable. Actually, using 503 or 429 response code for rate/conn limiting is a controversial topic. As for me, 429 HTTP code should be used when a specific client is breaking a contract by making too many requests over a certain period of time. It will be a bit strange if the client receives 429 on its first request.
P.S.:
This PR provides the ability to specify the needed status code. Could you please consider it?