Respond with 429 when throttled#528
Merged
pkieltyka merged 1 commit intogo-chi:masterfrom Jul 8, 2020
Merged
Conversation
Member
|
@VojtechVitek let us know what you think |
VojtechVitek
approved these changes
Jul 3, 2020
Contributor
VojtechVitek
left a comment
VojtechVitek
left a comment
There was a problem hiding this comment.
I agree with the above. LGTM.
Thanks for your contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Responding with
HTTP 429 Too Many Requestsstatus code seems more inline with what actually happened instead of the service unavailable response status code, because technically, the service is still available, it's just the sender has send too many requests in a given amount of time. (Typically a 400s error is client fault, whereas a 500s error is server).