Add input validation for ztest2 and some fix typo#226
Merged
pr0m1th3as merged 4 commits intognu-octave:mainfrom Jul 30, 2025
phychi:main
Merged
Add input validation for ztest2 and some fix typo#226pr0m1th3as merged 4 commits intognu-octave:mainfrom phychi:main
ztest2 and some fix typo#226pr0m1th3as merged 4 commits intognu-octave:mainfrom
phychi:main
Conversation
Added a check to ensure that X1 <= N1 and X2 <= N2 in the ztest2 function.
ztest2 sample sizes and some fix typoztest2 and some fix typo
Member
|
Thank you for the PR. For future reference, please open different PRs for different types of changes. For example, in this case, you could (should) open a PR for fixing typos in documentation, another for adding input validation in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a check to ensure that X1 <= N1 and X2 <= N2 in the
ztest2function. In addition, some spelling mistakes have been fixed.