Repository navigation
Commit 27b61fa
[fix](scanner) remove useless _src_block_mem_reuse to avoid core dump while loading (apache#17559)
The _src_block_mem_reuse variable actually not work, since the _src_block is cleared each time when we call get_block.
But current code may cause core dump, see issue apache#17587. Because we insert some result column generated by expr into dest block, and such a column holds a pointer to some column in original schema. When clearing the data of _src_block, some column's data in dest block is also cleared.
e.g. coalesce will return a result column which holds a pointer to some original column, see issue apache#175881 parent 406edc8 commit 27b61fa
2 files changed
Lines changed: 3 additions & 16 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
81 | 81 | | |
82 | 82 | | |
83 | 83 | | |
84 | | - | |
85 | 84 | | |
86 | 85 | | |
87 | 86 | | |
| |||
403 | 402 | | |
404 | 403 | | |
405 | 404 | | |
406 | | - | |
407 | 405 | | |
408 | 406 | | |
409 | | - | |
| 407 | + | |
410 | 408 | | |
411 | 409 | | |
412 | 410 | | |
| |||
437 | 435 | | |
438 | 436 | | |
439 | 437 | | |
440 | | - | |
441 | | - | |
442 | | - | |
443 | | - | |
444 | | - | |
| 438 | + | |
445 | 439 | | |
446 | 440 | | |
447 | 441 | | |
| |||
533 | 527 | | |
534 | 528 | | |
535 | 529 | | |
536 | | - | |
537 | | - | |
538 | | - | |
539 | | - | |
540 | | - | |
| 530 | + | |
541 | 531 | | |
542 | 532 | | |
543 | 533 | | |
| |||
809 | 799 | | |
810 | 800 | | |
811 | 801 | | |
812 | | - | |
813 | | - | |
814 | 802 | | |
815 | 803 | | |
816 | 804 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
106 | 106 | | |
107 | 107 | | |
108 | 108 | | |
109 | | - | |
110 | 109 | | |
111 | 110 | | |
112 | 111 | | |
| |||
0 commit comments