Skip to content

Comments

Release v2.2.2#613

Merged
skirpichev merged 15 commits intogmpy2:gmpy2-2.2.xfrom
skirpichev:release-v2.2.2
Nov 27, 2025
Merged

Release v2.2.2#613
skirpichev merged 15 commits intogmpy2:gmpy2-2.2.xfrom
skirpichev:release-v2.2.2

Conversation

@skirpichev
Copy link
Member

@skirpichev skirpichev commented Nov 25, 2025

Closes #602

@skirpichev skirpichev requested a review from mkoeppe November 25, 2025 04:59
@skirpichev skirpichev force-pushed the release-v2.2.2 branch 4 times, most recently from 2e67900 to 13ebfd1 Compare November 26, 2025 01:06
@skirpichev skirpichev marked this pull request as ready for review November 26, 2025 01:06
@skirpichev
Copy link
Member Author

This lacks version change and maybe commits from #617. Anything else?

* Sync with the master branch
* Build i686 on Linux
* Rename .github/workflows/build_wheels.yml
@mkoeppe
Copy link
Member

mkoeppe commented Nov 26, 2025

Should also build Linux aarch64 wheels (on ubuntu-24.04-arm), as already done in the master branch.

@skirpichev
Copy link
Member Author

Can be introduce wheels for new architectures in a patch release? If so, probably we should do same for Windows.

@mkoeppe
Copy link
Member

mkoeppe commented Nov 26, 2025

Also, looking at the macOS wheels

    cp38-macosx_x86_64: gmpy2-2.2.1-cp38-cp38-macosx_10_9_x86_64.whl 854.2 kB in a minute, SHA256=e6f46a6b5922dc42bb25edab2f9f408b96a5026d968996cea7e5ab3a681e8344
    cp39-macosx_x86_64: gmpy2-2.2.1-cp39-cp39-macosx_10_9_x86_64.whl 854.5 kB in a minute, SHA256=e376cfea3349b1243b1efa7f8513559b2fa34231601b37d8d22c0504e39328f3
    cp310-macosx_x86_64: gmpy2-2.2.1-cp310-cp310-macosx_10_9_x86_64.whl 854.6 kB in a minute, SHA256=161d430b2171627dabbbad0002054edac12e81b14380632a3c7bc37b802b0ed5
    cp311-macosx_x86_64: gmpy2-2.2.1-cp311-cp311-macosx_10_9_x86_64.whl 854.5 kB in 56 seconds, SHA256=ad21cb529aa2094607de81dc57b5bb58bde52b0ebf1440cc12504c1382462df2
    cp312-macosx_x86_64: gmpy2-2.2.1-cp312-cp312-macosx_10_13_x86_64.whl 854.7 kB in a minute, SHA256=399952a702e8341a2247f5ad8164aeb22d16eca594d952595bd5717055dd78a5
    cp313-macosx_x86_64: gmpy2-2.2.1-cp313-cp313-macosx_10_13_x86_64.whl 854.6 kB in 42 seconds, SHA256=e259e5b925355ddbf16b3d59d3f48ad60ebb4c1283178fc8428b8c5e32cec789
    cp314-macosx_x86_64: gmpy2-2.2.1-cp314-cp314-macosx_10_15_x86_64.whl 854.8 kB in 44 seconds, SHA256=5ddce42dd1b7eae6725f99074569757f6b7ffe4304515222e086b5844bb33359

I notice the different deployment targets.
Should we be setting MACOSX_DEPLOYMENT_TARGET explicitly?

Edit: In particular, comparing with https://pypi.org/project/gmpy2/2.2.1/#files, the bumped deployment targets for 3.12 and 3.13 are a regression

@mkoeppe
Copy link
Member

mkoeppe commented Nov 26, 2025

Can be introduce wheels for new architectures in a patch release? If so, probably we should do same for Windows.

Fine with me

Edit: Adding new architectures is always fine; only removing them shouldn't be done in a patch release.

@skirpichev
Copy link
Member Author

Should we be setting MACOSX_DEPLOYMENT_TARGET explicitly?

That did cibuildwheels:
https://github.com/pypa/cibuildwheel/blob/ea4b3eb6a5cd3aa7b944d5dc34b9c83ee832dfea/cibuildwheel/platforms/macos.py#L288-L305

the bumped deployment targets for 3.12 and 3.13 are a regression

I guess, that was for a reason, see comment in the code above and:
pypa/cibuildwheel#2612 (comment)

Adding new architectures is always fine

Ok.

@skirpichev skirpichev marked this pull request as draft November 26, 2025 07:50
@mkoeppe
Copy link
Member

mkoeppe commented Nov 26, 2025

Thanks for looking up these references, very helpful. For the 2.3.x series it's certainly a good idea to go with these well-argued defaults. Not sure about 2.2.x though.

@skirpichev
Copy link
Member Author

Not sure about 2.2.x though.

We can't target to different CPython patch-releases. If they changed things in such version - it's what it is.

@mkoeppe
Copy link
Member

mkoeppe commented Nov 26, 2025

pyproject.toml needs Python 3.14 in classifiers

@skirpichev skirpichev marked this pull request as ready for review November 26, 2025 10:23
@mkoeppe
Copy link
Member

mkoeppe commented Nov 26, 2025

The Linux aarch64 build is failing

@skirpichev skirpichev force-pushed the release-v2.2.2 branch 2 times, most recently from ff5d41b to 3c780a7 Compare November 27, 2025 00:47
Copy link
Member

@mkoeppe mkoeppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good now.

@skirpichev
Copy link
Member Author

Looking good now.

Not quite. musllinux images not filtered out for armv7l. I will update b8c2aca and then push version change.

@skirpichev skirpichev merged commit f549565 into gmpy2:gmpy2-2.2.x Nov 27, 2025
17 checks passed
@skirpichev skirpichev deleted the release-v2.2.2 branch November 27, 2025 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants