fix linting issues with golangci-lint 1.60.2#44
Merged
glours merged 1 commit intoglours:bump-engine-cli-v27.2.1from Sep 11, 2024
Merged
fix linting issues with golangci-lint 1.60.2#44glours merged 1 commit intoglours:bump-engine-cli-v27.2.1from
glours merged 1 commit intoglours:bump-engine-cli-v27.2.1from
Conversation
pkg/watch/watcher_darwin.go:96:16: Error return value of `d.stream.Start` is not checked (errcheck)
d.stream.Start()
^
pkg/prompt/prompt.go:97:12: Error return value of `fmt.Fprint` is not checked (errcheck)
fmt.Fprint(u.stdout, message)
^
pkg/prompt/prompt.go:99:12: Error return value of `fmt.Scanln` is not checked (errcheck)
fmt.Scanln(&answer)
^
cmd/formatter/logs.go:118:15: Error return value of `fmt.Fprintf` is not checked (errcheck)
fmt.Fprintf(w, "%s%s%s\n", p.prefix, timestamp, line)
^
cmd/formatter/logs.go:120:15: Error return value of `fmt.Fprintf` is not checked (errcheck)
fmt.Fprintf(w, "%s%s\n", p.prefix, line)
^
pkg/progress/json.go:67:15: Error return value of `fmt.Fprintln` is not checked (errcheck)
fmt.Fprintln(p.out, string(marshal))
^
pkg/progress/json.go:87:15: Error return value of `fmt.Fprintln` is not checked (errcheck)
fmt.Fprintln(p.out, string(marshal))
^
pkg/progress/plain.go:47:14: Error return value of `fmt.Fprintln` is not checked (errcheck)
fmt.Fprintln(p.out, prefix, e.ID, e.Text, e.StatusText)
^
pkg/progress/tty.go:162:12: Error return value of `fmt.Fprint` is not checked (errcheck)
fmt.Fprint(w.out, b.Column(0).ANSI)
^
pkg/progress/tty.go:165:12: Error return value of `fmt.Fprint` is not checked (errcheck)
fmt.Fprint(w.out, aec.Hide)
^
pkg/compose/attach.go:53:13: Error return value of `fmt.Fprintf` is not checked (errcheck)
fmt.Fprintf(s.stdout(), "Attaching to %s\n", strings.Join(names, ", "))
^
pkg/compose/compose.go:194:6: emptyStringTest: replace `len(dependencies) > 0` with `dependencies != ""` (gocritic)
if len(dependencies) > 0 {
^
pkg/compose/convergence.go:461:2: builtinShadow: shadowing of predeclared identifier: max (gocritic)
max := 0
^
pkg/compose/run.go:127:5: emptyStringTest: replace `len(opts.User) > 0` with `opts.User != ""` (gocritic)
if len(opts.User) > 0 {
^
pkg/compose/run.go:139:5: emptyStringTest: replace `len(opts.WorkingDir) > 0` with `opts.WorkingDir != ""` (gocritic)
if len(opts.WorkingDir) > 0 {
^
pkg/compose/viz.go:91:8: emptyStringTest: replace `len(portConfig.HostIP) > 0` with `portConfig.HostIP != ""` (gocritic)
if len(portConfig.HostIP) > 0 {
^
cmd/compatibility/convert.go:66:6: emptyStringTest: replace `len(arg) > 0` with `arg != ""` (gocritic)
if len(arg) > 0 && arg[0] != '-' {
^
pkg/e2e/watch_test.go:208:25: printf: non-constant format string in call to gotest.tools/v3/poll.Continue (govet)
return poll.Continue(res.Combined())
^
pkg/e2e/watch_test.go:290:25: printf: non-constant format string in call to gotest.tools/v3/poll.Continue (govet)
return poll.Continue(r.Combined())
^
Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
commented
Sep 11, 2024
| numberOfWatches.Add(int64(len(d.stream.Paths))) | ||
|
|
||
| d.stream.Start() | ||
| d.stream.Start() //nolint:errcheck // FIXME(thaJeztah): should this return an error? |
Author
There was a problem hiding this comment.
Left a TODO here as I wasn't sure if we could return the error
| _, _ = fmt.Fprint(u.stdout, message) | ||
| var answer string | ||
| fmt.Scanln(&answer) | ||
| _, _ = fmt.Scanln(&answer) |
Author
There was a problem hiding this comment.
This I wasn't sure about; perhaps could also require the error to be returned (but wasn't sure what kind of errors it returned)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pkg/watch/watcher_darwin.go:96:16: Error return value of
d.stream.Startis not checked (errcheck)d.stream.Start()
^
pkg/prompt/prompt.go:97:12: Error return value of
fmt.Fprintis not checked (errcheck)fmt.Fprint(u.stdout, message)
^
pkg/prompt/prompt.go:99:12: Error return value of
fmt.Scanlnis not checked (errcheck)fmt.Scanln(&answer)
^
cmd/formatter/logs.go:118:15: Error return value of
fmt.Fprintfis not checked (errcheck)fmt.Fprintf(w, "%s%s%s\n", p.prefix, timestamp, line)
^
cmd/formatter/logs.go:120:15: Error return value of
fmt.Fprintfis not checked (errcheck)fmt.Fprintf(w, "%s%s\n", p.prefix, line)
^
pkg/progress/json.go:67:15: Error return value of
fmt.Fprintlnis not checked (errcheck)fmt.Fprintln(p.out, string(marshal))
^
pkg/progress/json.go:87:15: Error return value of
fmt.Fprintlnis not checked (errcheck)fmt.Fprintln(p.out, string(marshal))
^
pkg/progress/plain.go:47:14: Error return value of
fmt.Fprintlnis not checked (errcheck)fmt.Fprintln(p.out, prefix, e.ID, e.Text, e.StatusText)
^
pkg/progress/tty.go:162:12: Error return value of
fmt.Fprintis not checked (errcheck)fmt.Fprint(w.out, b.Column(0).ANSI)
^
pkg/progress/tty.go:165:12: Error return value of
fmt.Fprintis not checked (errcheck)fmt.Fprint(w.out, aec.Hide)
^
pkg/compose/attach.go:53:13: Error return value of
fmt.Fprintfis not checked (errcheck)fmt.Fprintf(s.stdout(), "Attaching to %s\n", strings.Join(names, ", "))
^
pkg/compose/compose.go:194:6: emptyStringTest: replace
len(dependencies) > 0withdependencies != ""(gocritic)if len(dependencies) > 0 {
^
pkg/compose/convergence.go:461:2: builtinShadow: shadowing of predeclared identifier: max (gocritic)
max := 0
^
pkg/compose/run.go:127:5: emptyStringTest: replace
len(opts.User) > 0withopts.User != ""(gocritic)if len(opts.User) > 0 {
^
pkg/compose/run.go:139:5: emptyStringTest: replace
len(opts.WorkingDir) > 0withopts.WorkingDir != ""(gocritic)if len(opts.WorkingDir) > 0 {
^
pkg/compose/viz.go:91:8: emptyStringTest: replace
len(portConfig.HostIP) > 0withportConfig.HostIP != ""(gocritic)if len(portConfig.HostIP) > 0 {
^
cmd/compatibility/convert.go:66:6: emptyStringTest: replace
len(arg) > 0witharg != ""(gocritic)if len(arg) > 0 && arg[0] != '-' {
^
pkg/e2e/watch_test.go:208:25: printf: non-constant format string in call to gotest.tools/v3/poll.Continue (govet)
return poll.Continue(res.Combined())
^
pkg/e2e/watch_test.go:290:25: printf: non-constant format string in call to gotest.tools/v3/poll.Continue (govet)
return poll.Continue(r.Combined())
^
What I did
Related issue
(not mandatory) A picture of a cute animal, if possible in relation with what you did